sonic-net / sonic-platform-modules-dell

platform drivers for dell switches

platform drivers for Dell Z9100 for the SONiC project

sonic-platform-modules-dell's Issues

too many sleeps in s6100_platform.sh

admin@str-s6100-acs-1:/etc/init.d$ grep sleep /usr/local/bin/s6100_platform.sh
sleep 2
sleep 2
sleep 2
sleep 2
sleep 2
sleep 2
sleep 2
sleep 2
sleep 2

BCM Internal and CPU Internal temperature sensors are showing wrong values

BCM Internal:              +0.0 C  (high =  +0.0 C, crit =  +0.0 C)
CPU Internal:              +0.0 C  (high =  +0.0 C, crit =  +0.0 C)

either we could remove then or correct them.

modules don't get loaded after a fresh ONIE install or sonic_installer install

The Dell modules do not get loaded after a fresh ONIE install or an upgrade with sonic_installer. They get loaded upon reboot though.

init platform right after package installation

after package installed, it requires a reboot to finish platform init. sonic requires the platform init after package installation, it should not require a reboot.

After fstrim support, unit hangs on reboot

Build 523 added fstrim support via 8d4517d.

Though the unit comes up fine with the ONIE install, subsequent reboot/fast-reboot results in unit hung at:
[ OK ] Reached target Network is Online.
[ ***] A start job is running for LSB: Setup Z9100 board. (...40s / no limit)

dell_ich: probe of dell_ich.0 failed with error -16

[    4.284326] i2c /dev entries driver
[    4.297681] dell_ich: dell_ich: found SMF for ID 0x1
[    4.297790] dell_ich: dell_ich: request_region failed for GPIO : 500
[    4.297791] dell_ich: dell_ich dell_ich_probe failed with : -16
[    4.297797] dell_ich: probe of dell_ich.0 failed with error -16

sfputil show duplicate entries on s6100

vendor sn for Ethernet0 and Ethernet1 are the same. It should not be.

root@str-s6100-acs-3:/sys/devices/platform/dell_s6100_lpc# sfputil
Ethernet0: SFP detected

        Vendor SN : 1QA-0009782

Ethernet1: SFP detected
        Vendor SN : 1QA-0009782

hwmon support for dell platform drivers

needed for both s6100 and z9100

sensors output does not show any fan information or asic temperature on z9100

admin@str-z9100-acs-1:/etc/sonic$ sensors
coretemp-isa-0000
Adapter: ISA adapter
Core 0:       +31.0 C  (high = +98.0 C, crit = +98.0 C)
Core 1:       +32.0 C  (high = +98.0 C, crit = +98.0 C)
Core 2:       +32.0 C  (high = +98.0 C, crit = +98.0 C)
Core 3:       +32.0 C  (high = +98.0 C, crit = +98.0 C)

admin@str-z9100-acs-1:/etc/sonic$ 

fan status abnormal status

coretemp-isa-0000                                                                                                                                                                                                                                                                                                        [0/53]
Adapter: ISA adapter
Core 0:       +22.0 C  (high = +98.0 C, crit = +98.0 C)
Core 1:       +22.0 C  (high = +98.0 C, crit = +98.0 C)
Core 2:       +23.0 C  (high = +98.0 C, crit = +98.0 C)
Core 3:       +22.0 C  (high = +98.0 C, crit = +98.0 C)

dell-s6100-lpc
Adapter: S6100 Platform Management Controller
Onboard Temperature Sensors:
  CPU:                             29 C
  BCM56960 (PSU side):             31 C
  System Outlet 1 (switch board):  28 C
  BCM56960 (IO side):              26 C
  System Outlet 2 (CPU board):     29 C
  System Inlet Left (IO side):     21 C
  System Inlet Right (IO side):    21 C
  IOM 1:                           24 C
  IOM 2:                           24 C
  IOM 3:                           26 C
  IOM 4:                           25 C

Fan Trays:
  Fan Tray 1:
    Speed:     5569 RPM
    Fan 1:     Normal
    Fan 2:     Normal
    Air Flow:  F2B
  Fan Tray 2:
    Speed:     5593 RPM
   Fan 1:     Normal
    Fan 2:     Normal
    Air Flow:  F2B
  Fan Tray 3:
    Speed:     5609 RPM
    Fan 1:     Abnormal
    Fan 2:     Abnormal
    Air Flow:  F2B
  Fan Tray 4:
    Speed:     5585 RPM
    Fan 1:     Abnormal
    Fan 2:     Abnormal
    Air Flow:  F2B

PSUs:
  PSU 1:
    Input:           AC
    Type:            Normal
    FAN Speed:       7184 RPM
    FAN:             Present
    FAN Status:      Normal
    FAN AIRFLOW:     F2B
    Input Voltage:   229.00 V
    Output Voltage:   12.21 V
    Input Current:     0.54 A
    Output Current:    8.12 A
    Input Power:     111.00 W
    Output Power:     99.10 W
    Temperature:     47 C
  PSU 2:
    Input:           AC
    Type:            Normal
    FAN Speed:       7232 RPM
    FAN:             Present
    FAN Status:      Normal
    FAN AIRFLOW:     F2B
    Input Voltage:   228.75 V
    Output Voltage:   12.19 V
    Input Current:     0.63 A
    Output Current:    9.90 A
    Input Power:     132.00 W
    Output Power:    120.70 W
    Temperature:     48 C

  Total Power:       219 W

IO Modules:
  IOM 1: ON
  IOM 2: ON
  IOM 3: ON
  IOM 4: ON

sys eeprom is not attached in the s6100 init script

sudo sfputil does not work on z9100

admin@str-z9100-acs-1:~$ sudo sfputil
error reading port info ([Errno 2] No such file or directory: '/usr/share/sonic/device/x86_64-dell_z9100_c2538-r0/Traceback (most recent call last):\n  File "/usr/local/bin/sonic-cfggen", line 116, in <module>\n    main()\n  File "/usr/local/bin/sonic-cfggen", line 78, in main\n    data.update(parse_xml(minigraph, data[\'platform\']))\n  File "/usr/local/lib/python2.7/dist-packages/minigraph.py", line 397, in parse_xml\n    root = ET.parse(filename).getroot()\n  File "lxml.etree.pyx", line 3299, in lxml.etree.parse (src/lxml/lxml.etree.c:72655)\n  File "parser.pxi", line 1791, in lxml.etree._parseDocument (src/lxml/lxml.etree.c:106263)\n  File "parser.pxi", line 1817, in lxml.etree._parseDocumentFromURL (src/lxml/lxml.etree.c:106564)\n  File "parser.pxi", line 1721, in lxml.etree._parseDocFromFile (src/lxml/lxml.etree.c:105561)\n  File "parser.pxi", line 1122, in lxml.etree._BaseParser._parseDocFromFile (src/lxml/lxml.etree.c:100456)\n  File "parser.pxi", line 580, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:94543)\n  File "parser.pxi", line 690, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:96003)\n  File "parser.pxi", line 618, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:95015)\nIOError: Error reading file \'/etc/sonic/minigraph.xml\': failed to load external entity "/etc/sonic/minigraph.xml"/portmap.ini')
admin@str-z9100-acs-1:~$ 

Support for transceiver plug in/out event

Requirement:
https://github.com/Azure/SONiC/blob/gh-pages/doc/transceiver-monitor-hld.md#13-transceiver-plug-inout-event

control port led on z9100

how to control port led on s6100

Change platform init scripts as systemd jobs

Convert the z9100_platform.sh and s6100_platform.sh scripts as systemd jobs.

need to unload the platform modules

currently the driver stop is not implemented.

sensord doesn't write information to syslog periodically

since the current sensors command is overwritten, we lose the information of sensors output in the syslog that was once periodically logged into the syslog
this piece of information is useful

support platform deinit in z9100 platform

current platform module only support platform init, need to support platform deinit as well for platform driver upgrade scenario

Skip installing eeprom driver on non-existing devices.

echo sff8436 0x50 > /sys/bus/i2c/devices/i2c-$i/$1
this command needs to be executed only when the SFP is inserted.

[  110.270950] i2c i2c-18: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.354986] i2c i2c-19: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.438666] i2c i2c-20: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.523709] i2c i2c-21: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.607604] i2c i2c-22: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.696219] i2c i2c-23: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.796446] i2c i2c-24: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.896648] i2c i2c-25: Failed to register i2c client sff8436 at 0x50 (-16)
[  110.996833] i2c i2c-26: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.096999] i2c i2c-27: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.197201] i2c i2c-28: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.297407] i2c i2c-29: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.388211] i2c i2c-30: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.471924] i2c i2c-31: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.555546] i2c i2c-32: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.639164] i2c i2c-33: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.722900] i2c i2c-18: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.806522] i2c i2c-19: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.890144] i2c i2c-20: Failed to register i2c client sff8436 at 0x50 (-16)
[  111.973954] i2c i2c-21: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.061458] i2c i2c-22: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.161657] i2c i2c-23: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.261883] i2c i2c-24: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.362071] i2c i2c-25: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.462306] i2c i2c-26: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.562502] i2c i2c-27: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.662728] i2c i2c-28: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.754545] i2c i2c-29: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.838201] i2c i2c-30: Failed to register i2c client sff8436 at 0x50 (-16)
[  112.921877] i2c i2c-31: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.005525] i2c i2c-32: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.089183] i2c i2c-33: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.172937] i2c i2c-18: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.273153] i2c i2c-19: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.373422] i2c i2c-20: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.473594] i2c i2c-21: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.573762] i2c i2c-22: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.674114] i2c i2c-23: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.774141] i2c i2c-24: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.870162] i2c i2c-25: Failed to register i2c client sff8436 at 0x50 (-16)
[  113.954042] i2c i2c-26: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.037670] i2c i2c-27: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.121327] i2c i2c-28: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.204944] i2c i2c-29: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.288561] i2c i2c-30: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.372182] i2c i2c-31: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.455805] i2c i2c-32: Failed to register i2c client sff8436 at 0x50 (-16)
[  114.543503] i2c i2c-33: Failed to register i2c client sff8436 at 0x50 (-16)

sensors output does not show any fan information or asic temperature on s6100

root@str-s6100-acs-1:/home/admin# sensors
coretemp-isa-0000
Adapter: ISA adapter
Core 0:       +29.0 C  (high = +98.0 C, crit = +98.0 C)
Core 1:       +29.0 C  (high = +98.0 C, crit = +98.0 C)
Core 2:       +31.0 C  (high = +98.0 C, crit = +98.0 C)
Core 3:       +31.0 C  (high = +98.0 C, crit = +98.0 C)

depmod -a should only run in driver installation/uninstallation

depmod -a running in /usr/local/bin/s6100_platform.sh

this is not running every time when driver reload, could end up with file corruption.

pca954x probe failed on initializing I2c tree

sfputil breaks on s6100 and z9100

due to recent changes on sonic-net/sonic-buildimage@178fc03

please also add support for SFP presence, low-power mode and reset

Unknown status for power supplies