soos-io / soos-ci-analysis-circleci-orb Goto Github PK
View Code? Open in Web Editor NEWSOOS SCA for CircleCI
Home Page: https://soos.io/
License: MIT License
SOOS SCA for CircleCI
Home Page: https://soos.io/
License: MIT License
Hello SOOS team ๐
I am from the @circleci Community and Partner Engineering team, here to help with a review for the CircleCI orb partnership. I have a few action items below for you:
Changes:
Unless I am missing something, the only parameter you require in your executor is the tag. The rest are only used in your jobs/command.
Your parameter description mentions node
. I believe this should be python
based on the executor's name and docker image.
on_failure
parameter to enum or link to docs with the parameter's options:It sounds like this parameter has multiple options, but I couldn't easily find the accepted arguments in the orb or your docs. It's a good idea to make it an enum and/or insert the docs URL in the parameter description (example) for more information.
mode
parameter to enum.You did an excellent job explaining the valid arguments, and I believe you could further enforce them by making this parameter an enum.
requires
.Remove the lines: 206 and 270.
The options are listed and explained in the parameter description. There is no need to duplicate this information in the job description.
Optional:
Questions:
SOOS_BUILD_URI
and SOOS_OPERATING_ENVIRONMENT
. Do they serve any purpose?After addressing the issues above, please provide us with a successful run link. Should you have any questions, feel free to post them here, and I'll be happy to help!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.