souldanger / jekyll-pwa-workbox Goto Github PK

Hi,
If I enabled this plugin in my site, will it prompt user to allow or deny to notification like below

Or how can I send notifications to subscribed/installed users? Does user need to install this by clicking A2HS prompt to get notifications? I am totally new to this, hence the confusion...

In my site by installing pwa using android Firefox you can see that on opening app some images automatically loads in browser. I mean it going to some image links automatically.

Hi, thanks for making this plugin. I have already a service worker file for onesignal. can I put this plugin's service worker js code in sw.js file of that or can I use as a separate one.

So I build my Jekyll site on Github using a GitHub Action. When I test it locally, it compiles without a hitch. And when I only enable the PWA for my small recipes folder, it runs fine in both places.

But when I enable it for the drinks section I have, it breaks, but only when I run it on the GitHub Action (running ubuntu). it builds just fine on my local machine (Mac OS).

I think this might be how to fix it: https://stackoverflow.com/questions/23309669/ruby-encode-xc3-from-ascii-8bit-to-utf-8-encodingundefinedconversionerr/23382078

but I'm not sure if that means changing the code in the plugin or if I need to do something in the GitHub Action.

/github/workspace/vendor/bundle/ruby/2.7.0/gems/jekyll-pwa-workbox-5.1.41/lib/jekyll-pwa-workbox.rb:89:in `to_json': "\\xC3" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)
155
jekyll 3.9.0 | Error:  "\xC3" from ASCII-8BIT to UTF-8

Hi,

I ran into an issue when I changed the path of the sw_dest_filename to assests/js or any other sub folder. He issue was that the scope of the webmanifest was not the same as the scope of the service worker.
The scope of the webmanifest was set to "/", but the service worker was on "/assests/js/".

When registering a service worker it is also possible to pass the scope via the options parameter of navigator.serviceWorker.register, see https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer/register.

If found a good explanation on https://dev.to/njromano/how-to-scope-your-pwa-service-workers-1n6m.

Would it be possible to add it to the lib? Or would you accept a pull request?

Regards,

Jochen