spacha / circuitmod Goto Github PK

When a component (e.g. wire) has either of those choices selected and the user selects another, the other one remains on but doesn't show up (radio button-like behaviour). The other field is reactivated only by deselecting both and reselecting the option.

Used by components such as PotElm.

The layout is a bit janky, especially CircuitLayout. The right panel, "sidepanel", should have padding, the side ppanel should have fixed size while the canvas fills the rest of the space etc.

Currently, using keyboard to write input to edit dialog or interacting with other dialogs, the keyboard commands are also sent to the canvas, which should not happen (e.g. pressing x in a dialog changes the current tool to "Add text" and arrow keys move the active element).

Use a proper layout to align the labels and inputs.

https://www.iitk.ac.in/esc101/05Aug/tutorial/post1.0/converting/

They should be created in similar manner with text elements, without dragging.

• Mouse press: Create "drag element" to the mouse location
• Mouse release: Create the actual element to the release position

For example, with chip elements, such as VCO, the chip disappears if mouse is dragged to left. Also the posts are created according to the mouse release location (wrong!).

In Eclipse, one can use PackageExplorer > (right click root package) > Properties > Text file encoding.

Something is not right with the edit dialog. It seems that these bugs were introduced recently with version 2.7 (before this fork).

Resistor, inductor etc.: federoggio: "EditDialog.java in problems, when you put 100 in ohms in resistor, it set 99.8 ohms."

This happens with inductor, resistor, capacitor etc. (10 -> 9.92, 1k -> 99,2, ...)

Voltage source: changing the DC value sets the voltage to 0V (or 20V in some cases). This has something to do with the adjustmentValueChanged callback that sets the value after it has been already set in the text field.

This problem is not present in the released 2.7 version.

• Should not open multiple edit dialogs when changing the voltage source type
• Should not set voltage to random values (usually 0V or 20V)
• Should not change the resistance and other values from 1k to 99.2 etc.
• (minor) Should not flicker scrollbar on the text field | JDK-BUG

Currently undo and redo are very unreliable and unpredictable in their behavior. This should be fixed.

When a component or more are selected, they can be dragged using mouse. However, one would expect to be able to also move them using keys.

Benchmark (using circuit 555 Timer Chip/Internals):
Window size 860x640: 650 us
Window size 1920x1080: 3000 us

This could open in a separate window or (preferably) in the scope view.

Possible features

• set cursors
• measure frequency
• panning/zooming
• export waves to a file

JDK 9 has deprecated Applet API, which is used in CircuitMod. An alternative should be used.

Migration guide:

• https://www.oracle.com/technetwork/java/javase/migratingfromapplets-2872444.pdf
• https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/applet_dev_guide.html#JSDPG1032

Steps to reproduce:

1. Make a schematic
2. Add a text element
3. Select all (e.g. Ctrl+A)
4. Move all by dragging from a text element
5. Chaos.

After this dragging, the schematic becomes totally unusable, since all the following schematic interactions will be based on the discrete grid coordinated, while the existing schematic live in totally different coordinates, making new connections impossible.

For example, Diode class is a standalone prototype for diode elements (it has no parents). Inductor, on the other hand, extends CircuitElm.

For example, using potentiometer shows an extra slider for changing the resistance.

Steps to reproduce

1. Add a potentiometer

Especially useful with "pulse" source type. A small figure in the edit dialog could visualize the waveform with some details.

Related to #16.