spadarjauhien / flag-icons-rails Goto Github PK

View Code? Open in Web Editor NEW

35.0 1.0 18.0 5.39 MB

flag-icon-css sass gem for use in Ruby/Rails projects.

License: MIT License

Ruby 52.09% CSS 45.97% HTML 1.34% JavaScript 0.60%

rails rails-helper country-flags svg css icon-css icons-rails

flag-icons-rails's People

Contributors

Stargazers

Watchers

Forkers

craigsnowden marjaimate rorelessar tildedash nithinr07 harssh bichinger gambala br3nda damien-roche dzungvu drakkr-team bouchas romkor oleksandr-kolesnikov nduitz mtmail bhtabor

flag-icons-rails's Issues

Sass::SyntaxError: Undefined mixin 'flag-icon' - Error While Pre-compiling Assets.

Trying to pre-compile assets in production throws error:

rails aborted!
Sass::SyntaxError: Undefined mixin 'flag-icon'.
/home/solidus/vendor/bundle/ruby/2.5.0/gems/flag-icons-rails-2.5.0/app/assets/stylesheets/flag-icon-sass/flag-icon-list.scss:1:in flag-icon' /home/solidus/vendor/bundle/ruby/2.5.0/gems/flag-icons-rails-2.5.0/app/assets/stylesheets/flag-icon-sass/flag-icon-list.scss:1 /home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/tree/visitors/perform.rb:352:in block in visit_mixin'
/home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/stack.rb:98:in block in with_mixin' /home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/stack.rb:135:in with_frame'
/home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/stack.rb:98:in with_mixin' /home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/tree/visitors/perform.rb:350:in visit_mixin'
/home/solidus/vendor/bundle/ruby/2.5.0/gems/sass-3.5.5/lib/sass/tree/visitors/base.rb:36:in `visit'

application.css:
*= require flag-icon
*= require_tree .
*= require_self
*/

Does anyone have any clues?

Gem doesn't work on production mode

Add rubocop

https://github.com/bbatsov/rubocop

Add tests!

Fix dirty-hacked RuboCop config

In order to fix CI build failings, I've dirty-hacked rubocop config to avoid some issues on CI which was not reproduced on local machine. Need to fix it.

Add reek

https://github.com/troessner/reek

Integrate with Travis CI

Add Travis CI support to check builds quality. Implement it after #6.

Add information about contribution

Edit helper method

Replace second attribute with parameterized attribute

using dynamic country input

Hello,

What do you mean by:

Do not add gem to assets section if you want to use flag_icon rails helper.

Does that mean not to add:

@import "flag-icon";
to application.scss?

Also, how do I add dynamic content to the helper? I have an address model which has a country attribute. It stores the "BY".

I'm trying to pass that to the helper:


<%= flag_icon(Address.last.country) %>

        <%= flag_icon(Address.last.country.to_sym) %>

Neither of those attempts work. Can I use flags dynamically?

Precompiling assets after importing `flag-icon` from any file other than `application.scss` causes Segmentation Fault

Context:

I have a layout called share.html.erb that uses share.scss. When I try to
import 'flag-icon' in that file and try to precompile assets by running bundle exec rake assets:precompile it throws

/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-2.4.0/lib/sassc/engine.rb:43: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0059 p:---- s:0449 e:000448 CFUNC  :compile_data_context
c:0058 p:0314 s:0444 E:002130 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-2.4.0/lib/sassc/engine.rb:43
c:0057 p:0005 s:0432 E:002310 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-rails-2.1.2/lib/sassc/rails/template.rb:40
c:0056 p:0024 s:0429 E:0016b8 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/utils.rb:138
c:0055 p:0167 s:0422 E:000eb8 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-rails-2.1.2/lib/sassc/rails/template.rb:39
c:0054 p:0047 s:0413 E:000780 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84
c:0053 p:0014 s:0405 E:0014d0 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66 [FINISH]
c:0052 p:---- s:0400 e:000399 CFUNC  :reverse_each
c:0051 p:0035 s:0396 E:000f80 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65
c:0050 p:0016 s:0388 E:002230 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:22
c:0049 p:0010 s:0383 E:001e18 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:33
c:0048 p:0047 s:0378 E:000210 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84
c:0047 p:0014 s:0370 E:001a80 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66 [FINISH]
c:0046 p:---- s:0365 e:000364 CFUNC  :reverse_each
c:0045 p:0035 s:0361 E:0007c0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65
c:0044 p:0441 s:0353 E:0025d0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182
c:0043 p:0068 s:0331 E:001408 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59
c:0042 p:0034 s:0325 E:001c50 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337
c:0041 p:0141 s:0315 E:0015b8 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43
c:0040 p:0020 s:0306 E:001758 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44
c:0039 p:0103 s:0298 E:0019b0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:27
c:0038 p:0047 s:0280 E:001b40 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84
c:0037 p:0014 s:0272 E:000d40 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66 [FINISH]
c:0036 p:---- s:0267 e:000266 CFUNC  :reverse_each
c:0035 p:0035 s:0263 E:000a00 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65
c:0034 p:0441 s:0255 E:000ac0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182
c:0033 p:0068 s:0233 E:000a58 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59
c:0032 p:0034 s:0227 E:000990 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337
c:0031 p:0141 s:0217 E:001c38 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43
c:0030 p:0020 s:0208 E:001c58 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44
c:0029 p:0007 s:0200 E:000668 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:32 [FINISH]
c:0028 p:---- s:0194 e:000193 CFUNC  :each_key
c:0027 p:0023 s:0190 E:001ee8 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/2.7.0/set.rb:328
c:0026 p:0160 s:0185 E:0013e0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:31
c:0025 p:0047 s:0167 E:002040 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84
c:0024 p:0014 s:0159 E:000420 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66 [FINISH]
c:0023 p:---- s:0154 e:000153 CFUNC  :reverse_each
c:0022 p:0035 s:0150 E:001290 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65
c:0021 p:0441 s:0142 E:0011e0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182
c:0020 p:0068 s:0120 E:000598 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59
c:0019 p:0034 s:0114 E:0014c0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337
c:0018 p:0141 s:0104 E:0022a8 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43
c:0017 p:0020 s:0095 E:000b58 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44
c:0016 p:0034 s:0087 E:000ba0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/base.rb:81
c:0015 p:0023 s:0079 E:002698 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/base.rb:88
c:0014 p:0009 s:0068 E:000bd0 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/manifest.rb:125
c:0013 p:0020 s:0065 E:000c80 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/safe_ta
c:0012 p:0003 s:0058 E:000d10 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/synchronization/ [FINISH]
c:0011 p:---- s:0055 e:000054 CFUNC  :synchronize
c:0010 p:0016 s:0051 E:000ce0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/synchronization/
c:0009 p:0004 s:0047 E:000c38 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/safe_ta
c:0008 p:0023 s:0042 E:000d58 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/promise.rb:563
c:0007 p:0008 s:0036 E:000da0 METHOD /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_th
c:0006 p:0047 s:0028 E:000e68 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_th [FINISH]
c:0005 p:---- s:0022 e:000021 CFUNC  :loop
c:0004 p:0005 s:0018 E:000e20 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_th [FINISH]
c:0003 p:---- s:0015 e:000014 CFUNC  :catch
c:0002 p:0020 s:0010 E:000df0 BLOCK  /home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_th [FINISH]
c:0001 p:---- s:0003 e:000002 (none) [FINISH]

-- Ruby level backtrace information ----------------------------------------
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `block in create_worker'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `catch'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:335:in `block (2 levels) in create_worker'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:335:in `loop'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:352:in `block (3 levels) in create_worker'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:363:in `run_task'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/promise.rb:563:in `block in realize'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:19:in `execute'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:41:in `synchronize'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:41:in `synchronize'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:41:in `block in synchronize'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/concurrent-ruby-1.1.8/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:24:in `block in execute'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/manifest.rb:125:in `block (2 levels) in find'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/base.rb:88:in `find_all_linked_assets'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/base.rb:81:in `find_asset'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337:in `fetch_asset_from_dependency_cache'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59:in `block in load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182:in `load_from_unloaded'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `reverse_each'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66:in `block in call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84:in `call_processor'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:31:in `call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/2.7.0/set.rb:328:in `each'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/2.7.0/set.rb:328:in `each_key'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:32:in `block in call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337:in `fetch_asset_from_dependency_cache'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59:in `block in load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182:in `load_from_unloaded'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `reverse_each'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66:in `block in call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84:in `call_processor'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/bundle.rb:27:in `call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/cached_environment.rb:44:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:43:in `load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:337:in `fetch_asset_from_dependency_cache'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:59:in `block in load'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/loader.rb:182:in `load_from_unloaded'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `reverse_each'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66:in `block in call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84:in `call_processor'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:33:in `call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:22:in `block in <class:CompositeProcessor>'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:65:in `reverse_each'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:66:in `block in call_processors'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/processor_utils.rb:84:in `call_processor'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-rails-2.1.2/lib/sassc/rails/template.rb:39:in `call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sprockets-4.0.2/lib/sprockets/utils.rb:138:in `module_include'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-rails-2.1.2/lib/sassc/rails/template.rb:40:in `block in call'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-2.4.0/lib/sassc/engine.rb:43:in `render'
/home/ravi/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sassc-2.4.0/lib/sassc/engine.rb:43:in `compile_data_context'

However importing that from application.scss does not throw such error and the precompilation is successful. For now, I am using the predecessor gem, flag-icon-sass, and import 'flag-icon-sass' doesn't present any such issues with precompilation. But I would very much like to use this one as its new and more maintained. Thanks!

Big performance issue

Hi there,

I tried using this gem and noticed a direct increase of page response time of +1s.

Best,
Marc

sass dependency deprecated

Post-install message from sass:

Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.

* If you use Sass as a command-line tool, we recommend using Dart Sass, the new
  primary implementation: https://sass-lang.com/install

* If you use Sass as a plug-in for a Ruby web framework, we recommend using the
  sassc gem: https://github.com/sass/sassc-ruby#readme

* For more details, please refer to the Sass blog:
  http://sass.logdown.com/posts/7081811

We probably should head for the sassc-ruby gem as dependency...

Add Codacy badge to README

Here is badge:

Rename main SCSS file to flag-icon.scss

Rename main SCSS file to flag-icon.scss.

Update CSS library to current 2.8.0 version

https://github.com/lipis/flag-icon-css/releases/tag/2.8.0

'element' option does not work properly

flag_icon('es', element: :sup, class: 'custom-flag-icon')
#=> <span element="sup" class="flag-icon flag-icon-es  custom-flag-icon"></span>

Fix CI build failing

https://travis-ci.org/evgenygarl/flag-icons-rails/builds/281223188

Flag images not loading when importing into application.scss with postcss

Hi there, thanks for the awesome gem,
I have found an issue when the flags do not render in production but render in development mode on Rails 6 app.
The assets were loaded as comment in application.scss file:

/*
 *= require flag-icon
 */

And node processing css differently for development and production environments was the reason for flag icons not rendering in production.
During asset compilation I saw the message
$ NODE_ENV=${RAILS_ENV:-development} postcss ./app/assets/stylesheets/application.scss -o ./app/assets/builds/application.css
That explained it.

To resolve the issue with icons not showing up in production, I decided to change application.scss to import as:

// rails-flag-icon
@import "flag-icon";

However, asset compilation failed with error:

Error: Failed to find 'flag-icon'
  in [
    /Users/.../.../.../app/assets/stylesheets
  ]
    at /Users/.../.../.../node_modules/postcss-import/lib/resolve-id.js:35:13
    at async LazyResult.runAsync (/Users/.../.../.../node_modules/postcss/lib/lazy-result.js:396:11)
    at async Promise.all (index 0)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
rake aborted!
cssbundling-rails: Command css:build failed, ensure yarn is installed and `yarn build:css` runs without errors

Tasks: TOP => assets:precompile => css:build
(See full trace by running task with --trace)

So I tried manually adding the flag-icon.scss file and flag-icon-sass directory to app/assets/stylesheets. And ended up with error message:

yarn install v1.22.4
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.54s.
yarn run v1.22.4
$ NODE_ENV=${RAILS_ENV:-development} postcss ./app/assets/stylesheets/application.scss  -o ./app/assets/builds/application.css
CssSyntaxError: postcss-advanced-variables: /Users/.../.../.../app/assets/stylesheets/flag-icon-sass/flag-icon-list.scss:2:22: Could not resolve the variable "$include" within "$include"

  1 | @if variable-exists(include) {
> 2 |   @each $country in $include {
    |                      ^
  3 |     @include flag-icon($country);
  4 |   }

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
rake aborted!
cssbundling-rails: Command css:build failed, ensure yarn is installed and `yarn build:css` runs without errors

Tasks: TOP => assets:precompile => css:build
(See full trace by running task with --trace)

Is there any way to workaround different css compilation for development and production?

Improve readme file

Rename all mentions of flag-icon-sass gem

Rename all mentions of flag-icon-sass gem to new gem name flag-icons-rails.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble