Comments (15)
In a different code, we also had issues with axisymmetric. It seems to be more prone to round error issues. @sjplimp and @mgallis, what do you think?
from sparta.
I talked to @sjplimp about this and he would like to understand why this is happening. @aborner1 do you have a reproducer input script?
from sparta.
I only have large cases that reproduce it, I would need to see if I can generate something small that ideally can be run on a small number of procs, otherwise it's going to be a nightmare to debug.
from sparta.
@aborner1 I have assigned this issue to you. Once we have a reproducer I will reassign it to @sjplimp. Thanks.
from sparta.
This issue is possibly fixed by #194, @aborner1 can you confirm?
from sparta.
@stanmoore1 Will test the new code on large axisymmetric simulations. It wasn't something I could reproduce, so I will never be able to fully confirm, but unless the error reappears, I agree that this sounds like a logical fix.
from sparta.
Sounds good. We used fix check grid/check 1 error
to debug #194, that is a good option to turn on if you are seeing issues.
from sparta.
And global comm/sort yes
so it is reproducible.
from sparta.
@aborner1 I'm going to close this issue, but please reopen a new issue if you see the "Particle sent to self error" again.
from sparta.
@stanmoore1 @sjplimp I just encountered this error on a 3D run. So it is definitely still an issue in some cases. Hard to reproduce, as, once again, it happens on a large simulation after a few hours. Can a similar bug fix be implemented for 3D?
from sparta.
Can a similar bug fix be implemented for 3D?
There is no analogue for that axisymmetric issue in 3D, i.e. we tried in straight 2D and it works fine when a particle lands on the boundary.
Here is how I would recommend debugging this issue:
- Turn on
global comm/sort yes
so the runs are reproducible - Turn on
fix check grid/check 1 error
to better diagnose grid cell problems - Write out a restart file periodically, say every 10,000 steps
- When the simulation crashes after a few hours, increase the output frequency of restart files, i.e. write out a restart file every 1000 steps, and restart from the last checkpoint file to "zoom in" on the bug
- Keep zooming in until you have a reliable reproducer that runs in a hundred timesteps or less
- Send all the files (input and restart) to us for further debugging
from sparta.
I just got another "particle outside of cell" error in a large 2D axisymmetric simulation, even with the fix in #194. I'll try to debug.
from sparta.
#221 should fix any issues for axisymmetric by just deleting the particles.
from sparta.
@aborner1 can you try out #221 on your axisymmetric case? It should be a fix-all for these types of issues. Not sure why you would see issues in 3D though.
from sparta.
@aborner1 #221 should fix all axisymmetric issues so I'm going to close this issue. If you see more issues please let us know.
from sparta.
Related Issues (20)
- Qusetion about 'adapt_grid' command & 'fix adapt' command HOT 1
- Filter HOT 2
- Move/Surf HOT 7
- Cannot use region-style group command to create grid group HOT 2
- helium
- Normal flag in fix_emit_surf HOT 9
- Errors when removing surfaces from simulation HOT 4
- Particle count using transparent surface and issue with multiple core processors HOT 3
- tce/qk style HOT 3
- surf_react_adsorb LH1 reaction HOT 2
- Development of improved subsonic boundary condition and mass flow rate boundary condition HOT 9
- Fix emit/surf command fails when using equals-style variable for setting particle number HOT 3
- Configuration to avoid in order to cutcell algorithm to work or bug ?
- move_surf command
- Issue compiling SPARTA on ALCF's Polaris computer with kokkos enabled HOT 5
- Grid cell corner points on boundary marked as unknown HOT 2
- Illegal group command HOT 2
- Outdated documentation pages related to Section 6 of Manual
- Possible typos in adapt_grid manual page HOT 1
- Typo in dump_modify document HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sparta.