Highlight line in combination with emojis about commonmark-highlighter

[christophrumpel]

Thanks @allejo! Found a solution. @sebastiandedeyne showed me how @brendt managed something like that here https://github.com/brendt/stitcher.io/blob/master/src/Plugin/Markdown/HighlightCodeBlockRenderer.php 👍

[allejo]

Thanks for bringing this up to me, it appears to me like this is an upstream issue. I've fixed the issue over at scrivo/highlight.php#76.

After a bit more testing, I'll merge and a PR can be made against this repo for the new patch release.

[christophrumpel]

Thanks for taking care of it :-)

A bit unrelated, but do you think it would be possible to highlight just some fragments too instead of only lines?
Maybe by defining these parts in the code example ad it gets converted to HTML instead of showing the code?

    ```php
    $isUserPending = <span class="highlight">$user->isStatus('pending')</span>;
    ```

[sebastiandedeyne]

I think that's also more up to highlight.php to support, this is just a bridge between highlight and CommonMark.

[allejo]

A bit unrelated, but do you think it would be possible to highlight just some fragments too instead of only lines?

Maybe by defining these parts in the code example ad it gets converted to HTML instead of showing the code?

    ```php

    $isUserPending = <span class="highlight">$user->isStatus('pending')</span>;

    ```

Unfortunately not at the highlight.php level, see the discussion here scrivo/highlight.php#62

Highlighting like this would need to happen at the markdown extension level.

[christophrumpel]

@sebastiandedeyne so will the open PR be closed? Do I need to bring this bug to the other package?