sphereio / sphere-node-connect

Quick and easy way to connect your Node.js app with SPHERE.IO.

This repo has been integrated into sphere-node-sdk, please use related npm package as well.

sphere-node-connect's Issues

`query.limit` of PAGED should be compared as String and not as Number

Callback: Error object is `null` although request was not successful

I would expect that the callback is called with error not null when the REST request wasn' sucessful

Example:

@sync = new OrderSync config: Config.staging

@sync._rest.DELETE "/product-types/07d76cec-4c92-4c51-bf85-074ab329dcbc" (error, response, body) =>
  console.log "error #{error}"
  console.log "response #{response}"
  console.log "body #{body}"

# console log
error null
response [object Object]
body {"statusCode":400,"message":"Missing version number","errors":[{"code":"InvalidOperation","message":"Missing version number"}]}

Consider using "debug" for logging

https://github.com/visionmedia/debug

Advantages:

• ability to get only desired output via namespacing (e.g.: DEBUG=rest)
• easy to use
• normal output to stdout, which can be just piped to log files when used in production (e.g.: 2>/var/log/stderr.log)

Disadvantages:

• no more JSON logs

Deprecation notice

Use correct Logger API format

Call logs with correct format

https://github.com/trentm/node-bunyan#log-method-api

Provide functionality to renew the expired access token

If application is running for more than 3 days (which is the default expiration time for the OAuth2 access token), then access token would expire. At this point it would be nice if sphere-node-connect would be able to automatically (and transparently) renew it.

Because of the asynchronous nature of this operation, all incoming requests should be buffered and resumed as soon as new access token is arrived and ready to be used for the other HTTP requests.

Exports logger and configure it to be extended

Move Logger to a separate repo

In order to make the Logger class extendable without requiring the sphere-node-connect package we should move this in a separate repository (or integrate it in sphere-node-utils)

Use 'debug' level instead of 'info'