GithubHelp home page GithubHelp logo

rust-base24's People

Contributors

sphinxc0re avatar

Watchers

 avatar  avatar  avatar

rust-base24's Issues

Taking `&[u32]` instead of `&[u8]`

pub fn encode(&self, data: &[u8]) -> Result<String> {

Since the protocol specifies no padding, it makes little sense to encode a &[u8] and letting the encoder fail on non-divisible-by-4 array lengths.
If the user wants to encode a &[u8] then the user could use byteorder or some custom code to reinterpret the slice as u32.

This will make encoding infallible.

Return Result<T> instead of panicking

In the java version, I throw exceptions when the input has the wrong length or if invalid characters are present in the string to be decoded. But exceptions are normal error handling in Java but not in rust.

I suggest that encode and decode functions return Result types instead, for easier error handling in a rust way.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.