spigetorg / restapi Goto Github PK

If you try to download a file from a resource that links to an external download it will claim that no file was found. It would be nice to redirect to the external link instead.

Optionally this could also filter the external links to only redirect to ones that seem to actually link to files (ending in .jar/.zip) to not try to download some site although such a filter would be really error prone (e.g. with sites like Dropbox and Mediafire lying about the type of the response)

https://api.spiget.org/v2/resources/40483/versions/latest is showing a version for a completely different resource..? https://leeksapp.com/HhOzQh0sba.png

Both /updates and /versions are missing the latest update which was released 2 weeks ago and https://api.spiget.org/v2/resources/40483/versions?size=5&sort=-name has version 2.0.0 twice, which I'm guessing is because it was edited.

Using the version's name as the selector in /resources/<resource>/version returns version information about completely different resources.
This is likely due to the usage of ´is_numeric` as a check whether the version-ID or name was used in the URL (https://github.com/SpiGetOrg/RestAPI/blob/master/public/v2/index.php#L239)
Due to the cast to an integer, it selects the object ID if the requested name happens to be a double (https://github.com/SpiGetOrg/RestAPI/blob/master/public/v2/index.php#L261)

This php app doesn't include a list of dependencies, which makes contributing a little cumbersome. It's difficult to know what versions of your dependencies you're using (such as slim). As a recommendation using something like Composer would make this much easier.

When asking for the icon field via api request it does not return the icon object as documented.

Example url: https://api.spiget.org/v2/resources?fields=icon,name