GithubHelp home page GithubHelp logo

Tests broken on jRuby 19 about split HOT 8 CLOSED

splitrb avatar splitrb commented on August 18, 2024
Tests broken on jRuby 19

from split.

Comments (8)

buddhamagnet avatar buddhamagnet commented on August 18, 2024

I know we need to look into it.

from split.

m0wfo avatar m0wfo commented on August 18, 2024

Just tried running on my machine with JRuby 1.6.8 and 1.7 and everything passes :/ I'm using bundler v1.2.1, otherwise all gem versions are the same. Is there anything I'm missing about Travis's environment I wonder?

from split.

andrew avatar andrew commented on August 18, 2024

Maybe @rkh can provide some insight?

from split.

m0wfo avatar m0wfo commented on August 18, 2024

My JVM is the Oracle one (I suspect Travis uses a distro-supplied build) and it targets amd64 rather than i386 but Mr Google didn't turn up any architecture-related bugs. Both are at 1.7.0_07.

from split.

buddhamagnet avatar buddhamagnet commented on August 18, 2024

Oddly enough I made an innocuous commit to resque and the build
failed under jruby 1.9 also. A redis thing?

from split.

buddhamagnet avatar buddhamagnet commented on August 18, 2024

OK so it just happened again and looks like it fails any spec where an experiment is saved. Code for that method:

def save
  if new_record?
    Split.redis.sadd(:experiments, name)
    Split.redis.hset(:experiment_start_times, @name, Time.now)
    @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
  else
     Split.redis.del(name)
     @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
   end
 end

from split.

buddhamagnet avatar buddhamagnet commented on August 18, 2024

Just added a couple of specs to test atomic Redis operations (sadd and hset) under jruby...

from split.

andrew avatar andrew commented on August 18, 2024

Looks like mock_redis was completely borked on jruby, especially in 19 mode, it's been removed for now and the tests are passing again.

from split.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.