GithubHelp home page GithubHelp logo

drserv's People

Contributors

nresare avatar olivia5k avatar walles avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

drserv's Issues

There is no asynchronicity

Whenever I start working with a new server, I like doing a little async benchmark:

thiderman@justitia ~/spotify/drserv venv:drserv(master) 
> for x in {0..5}
    do echo "starting $x" && time drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa --auth-user=test --major-dist=squez --minor-dist=unstable --component=pls  /tmp/spotify-teamcity_8.1.4-1~0.0.0.50.8.0.3.0+10-38-g3ecc524.101_all.deb &
  done                                                                                  

starting 0
starting 1
starting 2
starting 3
starting 4
starting 5

drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.24s user 0.03s system 2% cpu 10.353 total
drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.23s user 0.03s system 1% cpu 20.373 total
drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.28s user 0.01s system 0% cpu 30.394 total
drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.27s user 0.03s system 0% cpu 40.413 total
drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.26s user 0.02s system 0% cpu 50.426 total
drserv-client --url http://localhost:3300 --key-file=test/pubkeys/id_rsa       0.24s user 0.03s system 0% cpu 1:00.44 total

As you can see, every upload is blocking and the last one takes a full minute. Hence, there is no asynchronicity!

There are two feasible ways of solving this:

  1. Use gevent and do gevent.monkeypatch(). This is ugly and doesn't always work.
  2. Make sure the code works in Python 3.4 and adopt the usage of aiohttp. This is prettier and nicer, but takes a bit longer, especially since crtauth currently does not support Python 3.

I personally vote for the latter!

Please enable Travis integration

Not sure it isn't already, but if it isn't, can you (for some value of "you") please enable Travis integration for this repo?

datadir should be /var/lib/NAME not /home/NAME

As the [http://www.pathname.com/fhs/](FHS 2.3) states:

An application (or a group of inter-related applications) must use a subdirectory of /var/lib for its data.`

/home is definitely not right for this. One might argue that /srv/NAME fits the bill, but /var/lib is better IMO.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.