spotlightforbugs / webwoelfe

Werwolf mit Freunden kostenlos online Spielen

SpotlightForBugs

Willkommen auf meinem Github-Profil!

Ich bin Johannes Häusler und angehender Student der Informatik an der FH Aachen.

webwoelfe's Issues

NEUES DESIGN, nach @ZORA

Namensvalidierung als Werwolf Modul

Alle Dateien hochladen

Rolle durch 'Tot' ersetzen

@BlackTesseract

Alles was passiert in einen log

Zb. Mit werwolf.log(1)

--> wenn 1, dann spiel beginnt in log schreiben usw.

Together we can

live update of Wahlbalken in Dash_Dorf

Beim Erstellen einer neuen Runde muss der Debug-Mode aus bleiben.

Das Problem liegt hier:

webwoelfe/werwolf.py

Lines 397 to 399 in de5fb20

	with open("logfile.txt", "w", encoding="UTF8") as file8:
	file8.truncate(0)
	file8.close()

Debug-Mode in werwolf.py:

webwoelfe/werwolf.py

Lines 397 to 398 in de5fb20

	with open("logfile.txt", "w", encoding="UTF8") as file8:
	file8.truncate(0)

Aktivierung und Verarbeitung des Debug-Mode:

webwoelfe/werwolf.py

Lines 606 to 646 in de5fb20

	def log(debug: bool):
	"""
	The log function writes a string to the logfile.txt file, which is used by the
	debug function to determine whether or not debug mode is on. If it's off, then
	the logfile will be wiped clean so that way it doesn't interfere with any future
	debugging efforts.
	:param debug:bool: Decide whether or not to write a logfile
	:return: A none object
	"""
	if debug == False:
	with open("logfile.txt",'w',encoding="UTF8") as logfile_schreiben:
	logfile_schreiben.write('FALSE')
	else:
	pass
	def in_log_schreiben(a: str):
	"""
	The in_log_schreiben function writes a string to the logfile.txt file.
	It takes one argument, which is a string.
	:param a:str: Pass the message to be logged
	:return: The result of the function
	"""
	with open("logfile.txt",'r',encoding="UTF8") as logfile_lesen:
	if 'FALSE' in logfile_lesen.read():
	logfile_lesen.close()
	else:
	with open("logfile.txt", "a", encoding="UTF8") as logfile:
	now = datetime.now().strftime("%H:%M:%S")
	logfile.write(str(now) + str(" >> " + a) + "\n")
	logfile.close()

öäü verursachen fehler

sentry link

Auch die Namensverifizierung in die Hexenfunktion einbauen

### TODO: Auch die Namensverifizierung in die Hexenfunktion einbauen

https://github.com/SpotlightForBugs/werwoelfe/blob/d1f7cd3c4b84c518e5ecbe3fb9e659149ac3b814/app.py#L795

(JS-0050) Avoid use of `==` and `!=`

Description

It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

Occurrences

There are 8 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/JS-0050/occurrences/

cookie-Magie

Aktionen für Hexe und Jaeger während des Todes

###TODO: Aktionen für Hexe und Jaeger während des Todes

https://github.com/SpotlightForBugs/werwoelfe/blob/4c08a7abcc71d016f421c778110f2e218eb02a86/werwolf.py#L342

Overwriting functions

Description
The verliebt status overwrites the actions on death of the Jaeger and the Hexe

To Reproduce
Steps to reproduce the behavior:

If a person with a role with actions on death dies, the person has no option to use the actions of their role

Expected behavior
A clear and concise description of what you expected to happen.

all platforms, the error occurs on the server-side

TemplateSyntaxError: Unexpected end of template. Jinja was looking for the following tags: 'endblock'. The innermost b...

Sentry Issue: FLASK-N

TemplateSyntaxError: Unexpected end of template. Jinja was looking for the following tags: 'endblock'. The innermost block that needs to be closed is 'block'.
(8 additional frame(s) were not displayed)
...
  File "jinja2\environment.py", line 969, in _load_template
    template = self.loader.load(self, name, self.make_globals(globals))
  File "jinja2\loaders.py", line 138, in load
    code = environment.compile(source, name, filename)
  File "jinja2\environment.py", line 768, in compile
    self.handle_exception(source=source_hint)
  File "jinja2\environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "C:\Users\jojon\OneDrive - Bischöfliches Pius-Gymnasium - Aachen\Desktop\webwoelfe\werwoelfe\templates\index.html", line 68, in template
    {% endblock %}

Übersicht nach Zoras Plan

Urls für die Dashboards fixen

Seherin Fähigkeit Rolle anzeigen

(PTC-W0010) File opened without the `with` statement

Description

Opening a file using with statement is preferred as function open implements the context manager protocol that releases the resource when it is outside of the with block. Not doing so requires you to manually release the resource.

Occurrences

There are 22 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/PTC-W0010/occurrences/

Daten in SQLite speichern

dass ist vollkommen integriert in der Sprache. Das bisschen SQL, was man braucht, bekommt man hin.
Dazu kann man ja eine "init" Routine machen, wenn es die DB noch nicht gibt.

test

Feature Request

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I have an issue when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version the docs.
Maybe a screenshot or design?

Mehrere Instanzen auf einmal

Nach-Tod-Aktionen (Jäger, verliebte und Hexe)

• Jäger kann nach dem Tot eine person töten
• Hexe kann nach dem Tot, wenn nicht schon aufgebraucht, eine Person töten

Sicherheitsabfrage bei der Anzeige des Logs

###TODO: Sicherheitsabfrage bei der Anzeige des Logs

https://github.com/SpotlightForBugs/webwoelfe/blob/58d8e610755d0ee11f825f485c1a6ccb43aaec2f/app.py#L891

Auswahl der beiden Partner:innen

<!--TODO- Auswahl der beiden Partner:innen->         

https://github.com/SpotlightForBugs/werwoelfe/blob/7be6067d8f2794c747f2adcc6642f0620eb79de4/templates/Dashboards/Dash_Armor.html#L12

(PYL-W0612) Unused variable found

Description

An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.

Occurrences

There are 7 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/PYL-W0612/occurrences/

Namen nicht länger als 15

Seherin Fähigkeit

Fix code scanning alert - Reflected server-side cross-site scripting

Tracking issue for:

• https://github.com/SpotlightForBugs/webwoelfe/security/code-scanning/3

Fähigkeiten Werwölfe

Als anhaltspunkt könnte man eventuell die allgemeine Wahl nutzen

Fix code scanning alert - Flask app is run in debug mode

Tracking issue for:

• https://github.com/SpotlightForBugs/webwoelfe/security/code-scanning/2

Rollen fähigkeiten Hexe

Darkmode und whitemode

• Nacht
• Tag
• Ergebnisseiten

mode = "dark" 
return (render_template('template',mode=mode))

Rollen fähigkeiten Jäger

JavaScript erzwingen

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 23: invalid continuation byte

Sentry Issue: FLASK-A

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 23: invalid continuation byte
(1 additional frame(s) were not displayed)
...
  File "flask\app.py", line 1525, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "flask\app.py", line 1523, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask\app.py", line 1509, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "app.py", line 452, in spezielles_Dashboard
    players_vorhanden = file.read()  # read the log file
  File "codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)

Neues Spiel Routine erstellen (Funktion in app.py erstellen die gecalled wird wenn ein neues Spiel erstellt wird)

Beim Hinzufügen Vairiable spieler_zahl auf 0 setzen

Logik des Spiels

Spielabläufe

(PYL-C0325) Unnecessary parentheses after keyword

Description

Extra parentheses in code can be removed for improved readability. In the examples below, the first example is more readable than the second one.

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/PYL-C0325/occurrences/

live display text file

(JS-0125) Found the usage of undeclared variables

Description

Variables that aren't defined, but accessed may throw reference errors at runtime.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/JS-0125/occurrences/

Spiel zuende routine (frontend)

Verhindern, dass jemand mit der Rolle Tot auf irgendeine URL zugreifen kann

(PY-S6007) Use of both safe and unsafe HTTP methods for a view

Description

An HTTP method is safe if it doesn't alter the state of the server i.e it leads to a read-only operation. Common safe HTTP methods: GET, HEAD, and OPTIONS. Whereas, POST, PUT, and DELETE are unsafe because they alter the server state. The use of both safe and unsafe HTTP …

Occurrences

There are 5 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/PY-S6007/occurrences/

Rollen Fähigkeiten Armor

(FLK-E722) Do not use bare `except`, specify exception instead

Description

Using except without a specific exception can be error prone.

Occurrences

There are 11 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/FLK-E722/occurrences/

Rollen_log kopieren, damit Rollenzuordnug möglich ist

(FLK-E501) Line too long

Description

Line length greater than configured max_line_length detected, defaults to 79 character. This limit can be configured docs

Occurrences

There are 10 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/SpotlightForBugs/webwoelfe/issue/FLK-E501/occurrences/

UnboundLocalError: local variable 'nurNamen' referenced before assignment

Sentry Issue: FLASK-2

UnboundLocalError: local variable 'nurNamen' referenced before assignment
  File "flask\app.py", line 2077, in wsgi_app
    response = self.full_dispatch_request()
  File "flask\app.py", line 1525, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "flask\app.py", line 1523, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask\app.py", line 1509, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "app.py", line 484, in spezielles_Dashboard
    nurNamen.append(name_line)  # append the name to the list

Amor als Rolle hinzufügen

Bei Toten soll die Rolle durch "Tot" ersetzt werden

          ###TODO : Bei Toten soll die Rolle durch "Tot" ersetzt werden

https://github.com/SpotlightForBugs/werwoelfe/blob/e887f319483d97096f75b03f9ddcc6ac84e40e4e/app.py#L378