Comments (4)
@handerson It was my understanding based on conversations with the TaxCloud CEO that because in US sales tax is only shipping-address-based, that they only want their API to be able to be used that way. If @JDutil or someone from Spree wants to weigh in and override that, then I'm open to that conversation, but otherwise the use of ship_address rather than tax_address was a deliberate choice. Perhaps you can get the behavior that you want just as easily by overriding shipping_address, rather than tax_address?
from spree_tax_cloud.
@brchristian Thanks for the quick reply. That makes sense. My concern with overriding shipping address is that it might have unintended consequences (either now or in the future). By using the tax address I was hoping to limit the effects to just taxes.
As far as I can tell everything still works as expected when I override ship_address, so I'll go that direction unless you decide to incorporate tax_address. Thanks again!
from spree_tax_cloud.
Tax address is there to enable these sort of customizations, however by doing so you open up the possibility for people to misuse it purposefully or unintentionally. So it would probably be fine to use it, but at the same time it's also probably wiser to leave as is to prevent people from messing things up.
from spree_tax_cloud.
@handerson Makes sense to be cautious about the override but I'm glad to hear that using ship_address seems to be working. For now based on the feedback from Jeff Dutil at Spree and David Campbell at TaxCloud it sounds like it's best to leave the extension as is, so I'm going to go ahead and close this issue for now. If this turns out to be a consistent request for other users, or if ship_address is causing unanticipated havoc we can always revisit.
from spree_tax_cloud.
Related Issues (20)
- Spec always fails the first time, succeeds the second HOT 3
- 2-3-stable spec failures HOT 1
- Product Specific TIC Field Missing in Admin HOT 5
- Refactor product tic field on products to use tax category code HOT 3
- This transaction has already been marked as authorized HOT 4
- required spree version HOT 3
- Tax amount of 0.0 returned HOT 13
- Address Verification Failed HOT 6
- Did not see tax on products on checkout page and cart page. HOT 2
- When adding a line item promotion to an order taxes are not re-adjusted with TaxCloud. HOT 4
- Calculate tax rate for items including discounts
- Spree 3.2 HOT 1
- Invalid apiLoginID and/or apiKey
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- SpreeTaxCloud ignores Spree's 'tax_using_ship_address' preference. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spree_tax_cloud.