SpreeTaxCloud ignores Spree's 'tax_using_ship_address' preference. about spree_tax_cloud

[brchristian]

@bobforever It's my understanding from conversations with TaxCloud staff that TaxCloud concerns itself exclusively with the shipping origin address and destination address, and does not take the billing address into account.

If I'm mistaken on this point, and TaxCloud is willing to accept either the user's shipping or billing address as the destination via their API, then I'm happy to make the change.

[bobforever]

That’s fair. It was easy to workaround this by copying an address, but it took a couple hours for me to track down what the issue was. by looking at various gem sources.

Perhaps the documentation should mention it will only look at the shipping address, regardless of the setting of Spree’s :tax_using_ship_addressss preference. Or perhaps throw an exception if that option is false.

We hadn’t been setting a separate shipping address because we are selling an online service and not shipping any physical goods.

-Bob

On Jul 14, 2014, at 7:51 PM, brchristian <[email protected]mailto:[email protected]> wrote:

@bobforeverhttps://github.com/bobforever It's my understanding from conversations with TaxCloud staff that TaxCloud concerns itself exclusively with the shipping origin address and destination address, and does not take the billing address into account.

If I'm mistaken on this point, and TaxCloud is willing to accept either the user's shipping or billing address as the destination via their API, then I'm happy to make the change.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-48974780.

[bbuchalter]

On Tue, Jul 15, 2014 at 7:40 AM, Robert Berger [email protected]
wrote:

We hadn’t been setting a separate shipping address because we are selling
an online service and not shipping any physical goods.

This is a good case for honoring Spree's preference.

[brchristian]

@bobforever I'm sorry you had to endure the long bug-hunt, and definitely agree that at the very least this should be noted in the README.

As to the question of using the store's tax address preference, I'm open to it but think that it should be run by someone at TaxCloud to see what the typical policy is for online-only orders. My tendency is to be conservative about feeding their API data it doesn't expect. I can imagine other stores in a similar position, though, so it'd be worth having that conversation

I'll see what I can do to make contact with TaxCloud and run it by them.

(For what it's worth, the "Spree::TaxCloud roadmap" includes scoping tax by Shipment, rather than Order, which is necessary in the case of split shipments, but only really makes sense if we're using the shipping_address. So we'll need to think about whether and/or how to accommodate online-only orders in that context too.)

[brchristian]

@bobforever From conversations with TaxCloud CEO David Campbell, he seems pretty clear that TaxCloud expects a shipping address unless there is none.

So, I think there's a compromise that will make TaxCloud happy but which will also enable stores like yours to work without needing to fork the extension, which is to always use ship_address but to fall back to billing_address if ship_address is nil.

And I'll go ahead and make note of this in the README.

That should take care of the issues you were experiencing. Thanks for mentioning it! And let me know if you have any further problems; of course we can always revisit.

[brchristian]

Thanks, @bobforever !