spring-cloud / spring-cloud-dataflow-common

Spring Cloud Connectors

Spring Cloud Connectors provides a simple abstraction that JVM-based applications can use to discover information about the cloud environment on which they are running, connect to services, and have discovered services registered as Spring beans. It provides out-of-the-box support for discovering common services on Heroku and Cloud Foundry cloud platforms, and it supports custom service definitions through Java Service Provider Interfaces (SPI).

Note	This project is in maintenance mode, in favor of the newer Java CFEnv project. We will continue to release security-related updates but will not address enhancement requests.

Learn more

See the project site and current documentation.

Build

The project is built with Gradle. The Gradle wrapper allows you to build the project on multiple platforms and even if you do not have Gradle installed; run it in place of the gradle command (as ./gradlew) from the root of the main project directory.

To compile the project and run tests

./gradlew build

To build a JAR

./gradlew jar

To generate Javadoc API documentation

./gradlew api

To list all available tasks

./gradlew tasks

Contributing

Spring Cloud is released under the non-restrictive Apache 2.0 license, and follows a very standard Github development process, using Github tracker for issues and merging pull requests into master. If you want to contribute even something trivial please do not hesitate, but follow the guidelines below.

Sign the Contributor License Agreement

Before we accept a non-trivial patch or pull request we will need you to sign the Contributor License Agreement. Signing the contributor’s agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. Active contributors might be asked to join the core team, and given the ability to merge pull requests.

Code of Conduct

This project adheres to the Contributor Covenant code of conduct. By participating, you are expected to uphold this code. Please report unacceptable behavior to [email protected].

Code Conventions and Housekeeping

None of these is essential for a pull request, but they will all help. They can also be added after the original pull request but before a merge.

• Use the Spring Framework code format conventions. If you use Eclipse you can import formatter settings using the eclipse-code-formatter.xml file from the Spring Cloud Build project. If using IntelliJ, you can use the Eclipse Code Formatter Plugin to import the same file.

• Make sure all new .java files to have a simple Javadoc class comment with at least an @author tag identifying you, and preferably at least a paragraph on what the class is for.

• Add the ASF license header comment to all new .java files (copy from existing files in the project)

• Add yourself as an @author to the .java files that you modify substantially (more than cosmetic changes).

• Add some Javadocs and, if you change the namespace, some XSD doc elements.

• A few unit tests would help a lot as well — someone has to do it.

• If no-one else is using your branch, please rebase it against the current master (or other target branch in the main project).

• When writing a commit message please follow these conventions, if you are fixing an existing issue please add Fixes gh-XXXX at the end of the commit message (where XXXX is the issue number).

spring-cloud-dataflow-common's Issues

Add custom MySQL database type

Update commons-io 2.7

Upgrade to Boot 2.3.x

Make docker compose test utils compatible with IT tests

So that we can try to remove palantir repo, make utils to work with dataflow IT tests for docker compose.

Fix changes in flyway

Flyway's Callback contains new method which we need to implement so that dataflow/skipper doesn't need to do it.

Remove commons-io dep management

Update Flyway 8.5.9 (Spring Boot 2.7.0-RC1)

The Spring Boot version of Flyway is 8.5.9 - we should stay in sync.

Remove commons-lang3 dep handling

Spring Boot 2.7.0-RC1 / Flyway 8.5.9 broke MariaDB/MySQL on SCDF

Since Flyway 8.2.1 the MySQL support is in a separate dependency org.flywaydb:flyway-mysql.

backport(13): Update commons-io 2.7

Backport #13

Please consider releasing 2.10 or a patch version for 2.9.x to include MySQL57Database changes

@onobc Please consider releasing above changes.

backport(9): Make docker compose test utils compatible with IT tests

Backport #9

Support resolving docker compose files from classpath

Currently you need to give absolute path or relative path and these are kinda annoying as gradle/maven/ide's will have different working directories. Might work better if i.e. in tests we could simply resolve absolute path from a classpath.

Add bom for easier dependency handling

Extract common flyway code

Dataflow and Skipper contain a lot of copy/pasted code for flyway feature which should be in a shared place.

Flyway issue with mysql GTID

With flyway you may get issue with GTID and happens when first starting either dataflow/skipper against same instance and later start other.

Migration  failed
-----------------
SQL State  : HY000
Error Code : 1786
Message    : (conn=153) Statement violates GTID consistency: CREATE TABLE ... SELECT.
Location   :  ()
Line       : 1
Statement  : CREATE TABLE `service_instance_db`.`flyway_schema_history_dataflow` (
    `installed_rank` INT NOT NULL,
    `version` VARCHAR(50),
    `description` VARCHAR(200) NOT NULL,
    `type` VARCHAR(20) NOT NULL,
    `script` VARCHAR(1000) NOT NULL,
    `checksum` INT,
    `installed_by` VARCHAR(100) NOT NULL,
    `installed_on` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
    `execution_time` INT NOT NULL,
    `success` BOOL NOT NULL,

Flyway 6.1.0 fixes this and would eventually get fixed with boot upgrade. Tracking here as boot 2.2.x is still on flyway 6.0.8.