squidfunk / terraform-aws-github-ci Goto Github PK

Description

GitHub webhook lambda function fails when triggered

Steps to reproduce the bug

terraform apply with version 0.4.1 of the module

The first noticeable failure is that when PRs are opened/updated, the AWS CodeBuild check no longer appears within the PR.

The AWS SNS integration is still in place and the lambda function does get triggered, but fails with:

TypeError: Cannot read property 'replace' of undefined
at /var/task/index.js:45:205
at Array.reduce (native)
at r.default (/var/task/index.js:44:19)

Package versions

• terraform-aws-github-ci: 0.4.1
• terraform: v0.11.3

Description

When running terraform apply:

github_repository_webhook._: POST https://api.github.com/repos/owner/repo/hooks: /hooks: 422 As of October 2018, GitHub Services can no longer be added. Please see the blog post for details: https://developer.github.com/changes/2018-04-25-github-services-deprecation
You can use the "Replacing GitHub Services" guide to help you update your services to webhooks: https://developer.github.com/v3/guides/replacing-github-services

Hey,

I have some needs to push additional resources to another bucket in my build.
Any ideas on how to accomplish that?
If you do - let me know, and I'll implement :)

https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md