ssardina-research / pypddl-translator Goto Github PK

In a domain def, some thignsthings are optional, but this is very badly handled by this code:

Re-do it following tarski solution:

go beyond 1ND oneof and allow nested oneof in effects.

• Zenotravel
  domain_zenotravel.txt

This has a forall that is not yet handled:

Originally posted by @ssardina in #4 (comment)

currently the precondition is limited to a list of literals, but preconditions can have way more:

Check full language of prec: https://planning.wiki/ref/pddl/domain#preconditions

The PyPDDL parser fails at these FOND domains (from the fond-sat repo):

• Earth Observation
  domain_earth_observation.txt

REMOVE METRIC STATEMENTS - the rest is fixed

• Faults
  domain_faults.txt

replace (and) with (and (true)) and add predicate (true)

• First Responders
  domain_first_responders.txt

lots of :requirements not accounted before, now they are

still there are many non-detet effects of the form (and) , they should be replaced with (and (true))

• Spiky Tireworld
  domain_spiky_tireworld.txt

one (and) to fix

• Tireworld
  domain_tireworld.txt

one (and) to fix

• Tireworld Truck
  domain_tireworld_truck.txt

two (and) to fix

• Zenotravel
  domain_zenotravel.txt

This has a forall that is not yet handled:

Another issue is the use of constants, that is much more basic and should be incorporated into the parser for sure:

Originally posted by @ssardina in #4 (comment)

OK this seems to be due to metrics:

Originally posted by @ssardina in #4 (comment)

Check the spec of PDDL 2.1 for metrics: https://planning.wiki/ref/pddl21/domain

@nitinef said:

Currently it is readonly.

e.g., after parsing the domain one cannot change the requirements (domain.requirements = new_requirements, will throw an error). This is because domain.py only has a getter and not a setter for requirements.