ssb-junkyard / ssb-replication-limiter Goto Github PK

When I was reviewing ssbc/ssb-ebt#15 I saw "setModeChangeThreashold" and was like, hang on, what sort of mode change is this threashold controlling? it took me a little while to figure out what that meant.

If a feed is behind by over a threashold (number of messages) it's switched to limited mode. maybe limitedThreashold or limitedModeThreashold would be a more obvious name?

Also, maxNumConnections, firstly "num" seems redundant because connections is plural, and "max" implies it's gonna be a number. But also, it's not actually about connections (i.e. connections to peers), it's about feeds. I'd suggest "maxLimitedFeeds" or "concurrentLimitedFeeds"