GithubHelp home page GithubHelp logo

Comments (6)

christianbundy avatar christianbundy commented on May 29, 2024 1

Instead of setting a font-family: NotoColorEmoji on all text we do:

.emoji {
  font-family: NotoColorEmoji;
}

Then you just pass an emoji property to ssb-markdown with a function like:

https://github.com/ssbc/patchwork/blob/c76136fb1628ec7fd4bb10b181d70ced01bb120c/lib/depject/message/html/markdown.js#L49-L57

(You can ignore the emojiMentions[emoji] condition, that's for Patchwork's "custom emoji" functionality that I've never actually seen working.)

from patchbay.

christianbundy avatar christianbundy commented on May 29, 2024

It's the emoji font! I've had this since the noto color emoji font was added. Happy to chat more about this if you'd like, we had to fix it in Patchwork.

from patchbay.

Powersource avatar Powersource commented on May 29, 2024

Sure, would be nice to fix. How was it fixed in patchwork?

from patchbay.

Powersource avatar Powersource commented on May 29, 2024

Remember that we need to update patchcore in patchbay before it works

from patchbay.

Powersource avatar Powersource commented on May 29, 2024

Can't get patchbay to build atm but I think this issue still applies since patchcore hasn't had a new release.

from patchbay.

stale avatar stale commented on May 29, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

from patchbay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.