sstephenson / hike Goto Github PK

View Code? Open in Web Editor NEW

141.0 141.0 24.0 310 KB

A Ruby library for finding files in a set of paths

License: MIT License

Ruby 100.00%

hike's Issues

gem should include the readme and license file

as none of the ruby files have a license header, you want to have some copyright/license in the gem file.

Release 1.2 gem

Broken link

The following file:
test/fixtures/app/views/.#application.js.coffee.erb

Is pointing at:
[email protected]

Which doesn't exists, it also seems to be a swp file (.application.js.coffee.erb.swp vi?) and ~ (index.html.erb~).

q

Ignore ~ files

Ignore vim swap files ~. Can you think of others? We already ignore . files.

ignore .orig files (leftover from git merge)

after a git merge, a .orig file is left on the file system and should be excluded from the filterlist.

very similar to issue #9 and pull request #10

Reduce Pathname usage

Pathname#absolute? and Pathname#join? are terrible slow. Lets axe as much as can. We still need to consider Windows while making these performance changes.

Hot spots:

https://github.com/sstephenson/hike/blob/master/lib/hike/cached_trail.rb#L115
https://github.com/sstephenson/hike/blob/master/lib/hike/cached_trail.rb#L122
https://github.com/sstephenson/hike/blob/master/lib/hike/cached_trail.rb#L137

sstephenson/sprockets#506

/cc @cheald

unexpected return (LocalJumpError)

a example from http://rubydoc.info/gems/hike/1.2.0/Hike/Trail:find

    trail.find("application") do |path|
      return path if mime_type_for(path) == "text/css"
    end

it raises

/home/guten/a/a.rb:8:in `block in <main>': unexpected return (LocalJumpError)
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:142:in `block in match'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:134:in `each'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:134:in `match'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:113:in `block in find_in_paths'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:112:in `each'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:112:in `find_in_paths'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:63:in `block in find'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:57:in `each'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/index.rb:57:in `find'
    from /usr/lib/ruby/gems/1.9.1/gems/hike-1.2.0/lib/hike/trail.rb:139:in `find'
    from /home/guten/a/a.rb:7:in `<main>'

Test on Brochure

Review API changes

Hey Sam, could you please review f5c25e0 and c0e5488 before I push a 1.2 gem.

Test on Sprockets

possible error in def build_pattern_for(basename)

sorry - I found my mistakes.

Missing tag for 2.1.3

Please add a tag for 2.1.3

about empty extension

trail = Hike::Trail.new
trail.extensions.push ".rb"
trail.paths.push "/tmp"
trail.find "foo"

for below files

/tmp/foo.rb
/tmp/foo

it finds "/tmp/foo". bug?

for another scene.

I want to find "/tmp/foo.rb", but we only have a "foo" file in "/tmp" directory, then it goes wrong.

I suggest like this

trail = Hike::Trail.new
trail.extensions.push ".rb", ""  # first find "foo.rb", then "foo"
trail.paths.push "/tmp"

let Trail#find supports to find absolute path

for example

hike = Hike::Trail.new
hike.extensions.push ".rb"
hike.paths.replace $:   # add $APP/lib/ into paths
hike.find("/etc/foo", "foo/rc", "~/.foorc") { |path|
    # do some thing here.
}

it will find /etc/foo, $APP/lib/foo/rc.rb, ~/.foorc files

Regression

This test is now failing in brochure

BrochureTest#test_index_templates_are_rendered_for_directories

The regression started in 0.5.x

Test suite fails

Hello, test suite fails on my computer (Fedora rawhide) with following errors:

$testrb test/
Loaded suite test
Started
...F...................................F.........................
Finished in 0.092777 seconds.
  1) Failure:
test_entries(IndexTest) [./test/test_trail.rb:190]:
<[#<Pathname:application.js.coffee.erb>,
 #<Pathname:application.js.coffee.str>,
 #<Pathname:index.html.erb>,
 #<Pathname:layouts>,
 #<Pathname:projects>,
 #<Pathname:projects.erb>,
 #<Pathname:recordings>]> expected but was
<[#<Pathname:application.js.coffee.erb>,
 #<Pathname:application.js.coffee.str>,
 #<Pathname:index.html.erb>,
 #<Pathname:layouts>,
 #<Pathname:projects.erb>,
 #<Pathname:projects>,
 #<Pathname:recordings>]>.
  2) Failure:
test_entries(TrailTest) [./test/test_trail.rb:190]:
<[#<Pathname:application.js.coffee.erb>,
 #<Pathname:application.js.coffee.str>,
 #<Pathname:index.html.erb>,
 #<Pathname:layouts>,
 #<Pathname:projects>,
 #<Pathname:projects.erb>,
 #<Pathname:recordings>]> expected but was
<[#<Pathname:application.js.coffee.erb>,
 #<Pathname:application.js.coffee.str>,
 #<Pathname:index.html.erb>,
 #<Pathname:layouts>,
 #<Pathname:projects.erb>,
 #<Pathname:projects>,
 #<Pathname:recordings>]>.
65 tests, 87 assertions, 2 failures, 0 errors

Notice the swapped 'projects.erb' and 'projects' pathnames It seems that somewhere should be applied some sorting to keep the results consistent.

Support for finding files relative to another file

Something like:

trail.find("./index", :relative_to => filename)

It should ensure that the result actually exists in the path.

sstephenson / hike Goto Github PK

hike's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs