stakx / dynamicproxy.asyncinterceptor Goto Github PK

Following the advice given in castleproject/Home#14, it should probably be stakx.DynamicProxy.

Can we deduplicate effort and merge with https://github.com/JSkimming/Castle.Core.AsyncInterceptor?

GitHub still forwards to the correct file, but code files should mention the definite license URL nevertheless.

... instead of performing the same reflection calls over and over again.

Applying this custom attribute here is probably a mistake, since according to the .NET API documentation page its purpose is this:

Indicates whether a method is marked with either the Async or async modifier.

Which isn't the case for AsyncInterceptor.Intercept.

IAsyncInvocation currently offers only a subset of the capabilities available in the original IInvocation. Some of those have to be restricted (e.g. the ability to mutate by-ref arguments, or the ability to set the raw return value), but others are still missing and need to be added back.

https://github.com/stakx/AsyncInterceptor/blob/dc3d7693ec04c791cc540eafa88c514907975577/AsyncInterceptor/AsyncInterceptor%2BAsyncInvocation.cs#L37-L41

Shouldn't the above be wrapped in a faulted Task the same way done a little further down?:

https://github.com/stakx/AsyncInterceptor/blob/dc3d7693ec04c791cc540eafa88c514907975577/AsyncInterceptor/AsyncInterceptor%2BAsyncInvocation.cs#L44-L57