The weathersim from stalej

weathersim's Issues

get data -all command in client

Arbeidsoppgave:
- Make the "get data -all" return all the data form the database

client_server.py talking to database

Fix broken get all command

This method is flawed. We need to make a second request to find the size file we are sending.

def request_to_server(request: str) -> str:
    sock.sendall(request.encode())
    resp = sock.recv(16384)
    return resp.decode()

We need

sock.reciv(file_size)

So that we don't overflow the recv buffer

Implement more get request commands on client side

Vi må lage flere muligheter til flere kommandoer som vi kan sende i "terminalen".

Forslag kan være

get data <day>
get data <place>
get data <month>
get data rain
get data temp

Catch OSError by error code

Må finne en måte å catche OSError

Arbeidsoppgave:
- finne en måte å catche OSError
- klare å catche OSError error code

client_server.py talking to client

TCP connection to client
Handle simple requests: getall, help etc

get data all fails in WeatherAppClient.py

Error when trying to fetch all data form data.json

WAclient> get data all
Traceback (most recent call last):
  File "WeatherAppClient.py", line 107, in <module>
    get_all_data()
  File "WeatherAppClient.py", line 29, in get_all_data
    all_data = get_json("getall")  # loads converts str -> dict
  File "WeatherAppClient.py", line 16, in get_json
    _data = json.loads(request_to_server(request))
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Unterminated string starting at: line 1 column 1 (char 0)

README fix

A small error in the readme. data sender is not on the server but station

$ python server/server.py
$ python server/weather_station_data_sender.py
$ python server/client_server.py
$ python client/WeatherAppClient.py

Refactor WeatherAppClient.py

Arbeidsoppgave:
- make code look bootyful 🏭

Either the Readme is not correct or the code is not correct

Describe the bug:
When in the project root directory, if you run the code from as described in the readme the code will fail eventually. It is caused by that the files/servers are coded to be run from the folder they are in.

So we could either change the readme or the code:

A change in the readme would look like:

Then run from project root:

$ cd server
$ python server.py
$ python weather_station_data_sender.py
$ python client_server.py
$ cd ../client
$ python WeatherAppClient.py

or a code change would look going from, for example this:

DATABASE = "data.json"
HELP = "requests.json"

to this:

DATABASE = "./server/data.json"
HELP = "./server/requests.json"

in every relevant files. What you guys think?

Problems on mac?

Can someone one Linux or windows check if weatherappclient can still talk to the server? or it's a mac problem?

λ python3 WeatherAppClient.py                                                                                                                        ⏎ [3m] ✭
Press Enter to exit
WAclient> get data all
Traceback (most recent call last):
  File "/Users/stale/Skole/oblig1-142/client/WeatherAppClient.py", line 102, in <module>
    get_all_data()
  File "/Users/stale/Skole/oblig1-142/client/WeatherAppClient.py", line 36, in get_all_data
    all_data = get_json("getall")  # loads converts str -> dict
  File "/Users/stale/Skole/oblig1-142/client/WeatherAppClient.py", line 23, in get_json
    _data = json.loads(request_to_server(request))
  File "/Users/stale/Skole/oblig1-142/client/WeatherAppClient.py", line 14, in request_to_server
    size_of_file = int(sock.recv(512).decode())
ValueError: invalid literal for int() with base 10: ''

Documentation is not very correct.

In the diagram model ther eis inacurate URL for the website. It says 30group.code.
Se picture
The correct URL is group30.codes

Create help command in client

Arbeidsoppgave:
- Make help command return all available commands.

stalej / weathersim Goto Github PK

weathersim's People

Contributors

Stargazers

Watchers

weathersim's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs