stanepp / opengl_particlesystem Goto Github PK

From ShaderManager.cpp:

GLsizei* length = new GLsizei; //new is not needed. just GLsizei length = 0; is ok then you just pass it's address in the function below It's not an array. It's just a value.
You can use it like this:
glGetShaderiv(shaderID, GL_INFO_LOG_LENGTH, &length);
char* compilationLog = new char[length];
glGetShaderInfoLog(shaderID, length, NULL, compilationLog);

throw std::exception(([...]+std::string(compilationLog)).c_str()); //Throwing here means you never deallocate compilationLog ( and never deallocate "length" from the original code )

How do I configure the GLFW dependency properly?
In VS2019 I go File - Open - CMake… then it opens the project but fails to build it with this error:
particlescompute\ninja : error : 'glfw-NOTFOUND', needed by 'OpenGL_Particlesystem.exe', missing and no known rule to make it

Sorry, I'm clueless around cmake

Undefined symbols for architecture x86_64:
"_CFBundleCreate", referenced from:
_open_libgl in gl3w.c.o
"_CFBundleGetFunctionPointerForName", referenced from:
_get_proc in gl3w.c.o
"_CFRelease", referenced from:
_close_libgl in gl3w.c.o
_get_proc in gl3w.c.o
"_CFStringCreateWithCString", referenced from:
_get_proc in gl3w.c.o
"_CFURLCreateWithFileSystemPath", referenced from:
_open_libgl in gl3w.c.o
"___CFConstantStringClassReference", referenced from:
CFString in gl3w.c.o
"_kCFAllocatorDefault", referenced from:
_open_libgl in gl3w.c.o
_get_proc in gl3w.c.o
ld: symbol(s) not found for architecture x86_64

Could you add some license (or, if you don't want others to fork your code, explicitly state that)?

I get this build error in the solution generated by CMake
Error C2664 'void ShaderManager::loadShader(const std::string &,const std::string &,GLenum)': cannot convert argument 1 from 'std::filesystem::path' to 'const std::string &' OpenGL_Particlesystem C:\Users\a\Documents\particlescompute\src\ParticleSystem.cpp 63

Where is the executable file?