stansassets / com.stansassets.build Goto Github PK

Codebase contains different names for the same thing:

• all essential building blocks have the Task postfix
• pipeline visualization use the name step
• some components use both variants for the variable/method names in the same context
  https://github.com/StansAssets/com.stansassets.build/blob/master/com.stansassets.build/BuildPipeline/Core/BuildProcessor.cs#L67

I think we should unify the name in order to not introduce ambiguity out of nowhere for the package users and maintainers.

Now we use Unity interface + attributes.
https://github.com/StansAssets/com.stansassets.build/blob/master/com.stansassets.build/BuildPipeline/Core/BuildProcessor.cs

Make sure interfaces are compatible with Unity 2019.4.

https://docs.unity3d.com/ScriptReference/Build.IPreprocessBuildWithReport.html
https://docs.unity3d.com/ScriptReference/Build.IProcessSceneWithReport.html
https://docs.unity3d.com/2019.4/Documentation/ScriptReference/Build.IPostprocessBuildWithReport.html

Here is an issue.
When we storing the commit time - we getting GMT time from the git hub
So in order to make it look my time - I need to all adjust it for the my time zone.

Build time - unlike the commit time uses time zone on the current machine.

Solutins: We need timezone settings GMT +X
This way we will add time zone to the git commit time
We will remove the machine timezone from the build time making it GMT time and then will add time zone from settings to the result.

Cloned repo gives me a unity project with error cause the 'Foundation' dependency is set as local with absolute path in manifest.json:

"com.stansassets.foundation": "file:/Users/stan/Documents/StansAssets/com.stansassets.foundation",

Right now we only should our own registered tasks.
Would be nice to see all the scripts that are using:

• IPreprocessBuildWithReport
• PostProcessScene
• PostProcessBuild
  This way we will be able to know when our tasks will be executed in the whole player build pipeline.

The feature request is closed due to an enormous amount of effort w/o guaranteed result.

• Make sure we avoid abstract / interfaces, ects.
• See DefaultBuildTasksProvider
• Check if type has empty constructor and throw appropriate exception if it's not (DefaultBuildTasksProvider line 14)

• NPM js
• Opem UPM

• See BuildProcessor.RunBuildTask
• Also make sure Async tasks are marked in the build pipeline window (you can just add (async) postfix)

https://github.com/StansAssets/com.stansassets.build/blob/master/com.stansassets.build/BuildPipeline/Interfaces/Tasks/Async/IAsyncBuildTask.cs

Asking because:

1. Can't handle Exception properly
2. Can't pass any complete argument. For example we failed the Task, but the is no option to tell the system about that.

The IBuildTasksContainer should contain only types:

Example: IReadOnlyList<Type> PreBuildTasks { get; }

https://github.com/StansAssets/com.stansassets.build

• Incremental builds
• Displaying metadata
• Build steps

• Make sure only one IAdvancedBuildStepsProvider can be registered per project.
• See BuildProcessor.CreateBuildTasksProvider

First row

• Make it bold
• Make it static

Date format - ideally we should give an ability to set the preferred date format for the sell
Cell width - would be nice to give it a default width

• check why Hyper link gives an error.

Currently, there is no way to change the step execution order of IBuildTask - they simply add to the list sorted by the class name.
We can introduce a custom class attribute [StepExecutionOrder(int order)] and perform a sorting based on this parameter.

Also, it will be helpful to add an attribute [StepName] in order to override the default one in the pipeline visualization, because the current name displaying method will lead to ambiguity when classes have the same name but relate to different modules/assemblies.
It is also possible to just use a GetType().FullName or add a parameter in settings that allows the user to select the name displaying method.