starkware-libs / starkex-resources

Stark Exchange Resources

This repo hold a collection of tools to support the Stark Exchange. The Stark Exchange is a STARK-powered scalability engine for crypto exchanges. It uses cryptographic proofs to attest to the validity of a batch of transactions (such as trades and transfers) and updates a commitment to the state of the exchange on-chain.

The Stark Exchange allows exchanges to provide non-custodial trading at scale with high liquidity and lower costs.

Modules

1. committee - Reference committee member service implementation
2. crypto - A cryptographic library for the Stark Exchange
3. storage - A storage abstraction library
4. stark_ex_objects - Various python objects used by the Stark Exchange

Copyright

Copyright 2020 StarkWare Industries Ltd.

Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with the License. You may obtain a copy of the License at

https://www.starkware.co/open-source-license/

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

starkex-resources's Issues

batch_info.json - expected size

Hi,

What is the expected size of the batch_info.json?

My guess is:
~expected number of orders per second: 5
x
2 sides of an order
x
ratio of orders touching unique accounts:: <1
x
polling interval
x
size of single update

So I see that a single batch should be roughly ~10Kb?

Useability

Dear team, within your documentation you re saying that it is possible to deposit and withdraw funds on your network: https://docs.starkware.co/starkex-v3/starkex-deep-dive/smart-contracts-1/public-interactions, you even mention the functions to use.
But you do not say what's the contract address and how to call them and how to connect to your network.
Basically we would like to assess how much it costs to use your network in order to trade token.

Thanks

Pedersen function of signature.js cannot hash starknet public keys

Issue

Signaure.js serves as a library to perform cryptographic functions required in starknet smart-contracts. The Pedersen Hash implementation in it doesn't allow for hashing of starknet public keys.

The issue is due to failure of assertion inside the function, which only takes input between 0 (not included) to '800000000000011000000000000000000000000000000000000000000000001'.

assert(x.gte(zeroBn) && x.lt(prime), 'Invalid input: ' + input[i]);

The python implementation of the same function is able to compute the pedersen hash.

verify function doesn't work correctly, plz also add a test case for that.

• Sign a message with sign function and try to verify it, verification function will return false always even if hash and signature passed is correct.

Feat: Useability #7

To interact with the StarkWare network for depositing and withdrawing funds, refer to the documentation provided at https://docs.starkware.co/starkex-v3/starkex-deep-dive/smart-contracts-1/public-interactions. Find contract addresses for deposit and withdrawal functionalities, and look for code examples or instructions on calling these functions. Connect to the network by specifying a network URL or RPC endpoint as outlined in the documentation's "Connecting to the StarkWare Network" section. Assess the costs of using the network by examining transaction fees and fee structures detailed in the documentation.

ecdsa library optimization

i notic that starkware is not using the secp256k1 curve.

however, i compared the ecdsa sign to bitcoin library secp256k1, it is much slower. libsecp256k1 only takes 85 micro per iteration.

after some digging, the current implementation does not adopt the jacobian coordinates as in libsecp256k1.

any plan to optimize that?