stassius / metaparser Goto Github PK

Describe the bug
The developers of Controlnet pushed an update today which changed the way Controlnet formats its PNG metadata. I ran a quick test and their change causes issues on the Metaparser output (Incorrect info for Controlnet items).

Their developer discussion on this topic/change: Mikubill/sd-webui-controlnet#1180

To Reproduce
Steps to reproduce the behavior:

1. Update Controlnet
2. Output an image with Controlnet enabled
3. Open in Metaparser
4. Notice controlnet items are misaligned or incorrect

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Saw the post first and immediately assumed it would cause issues w/ MetaParser which it does seem to do. They breakdown the before and after Metadata changes which should indicate what needs to be adjusted code-wise. Thanks!

Is your feature request related to a problem? Please describe.

Just a request to add the date the image was generated to the list of information provided. Could pull this from Windows/OS, but I'd find it helpful when browsing folders of images.

Describe the solution you'd like

Date generated added to list of information.

Additional context

Not a big deal - just something I'd personally find helpful (I find myself dropping back to Windows to check the date since it's not among the rest of the data in MetaParser). I mainly use the date to get an idea of how old the model I used was. I often have a bunch of Dreambooth models for people I like, but my technique/methods for making them has changed over time. It's helpful for me to know if it's from a model I created when I first started w/ training or something more recentl.

Maybe this is something that could be added if there is a more substantial update down the road. Thx!

Describe the bug
Hi, first I just wanted to say that I've been looking for a tool like this for a while - thank you so much for your time and effort!!

I get "Error Reading File" for a lot of PNGs that I've generated w/ A1111. I'm on the most recent commit, but do use a few extensions that might add extra metadata that breaks functionality (?). Here are example of 3 images that Metaparser reads properly, and 3 that display "Error Reading File" from a batch of images I generated today.

(Updated: After comparing prompts further, it appears the "Dynamic Thresholding" extension adds text that breaks Meaparser's ability to read PNGs properly):

Don't work / Display "Error Reading File"

https://drive.google.com/file/d/1-sU4nO5hNb3klRQ9zgC1GBCBKCdW8Av7/view?usp=sharing
https://drive.google.com/file/d/1IOJa_BxAbOZSxsG3IqkqagdBAmnSfuNR/view?usp=sharing https://drive.google.com/file/d/1g5Ldzdq5Ig4pnq1PsnDnVbBlsw9eXv73/view?usp=sharing

Work/Don't produce "Error Reading File"

https://drive.google.com/file/d/159vvFkL3bAoLk6dkozfdBGiGwctGFLkv/view?usp=sharing
https://drive.google.com/file/d/1E-vyEJWo60yLn6wPEyhaftlbuoMIoORY/view?usp=sharing
https://drive.google.com/file/d/1m27Rf1uutBtWSaJ5CIK8LtcRSX6toYcr/view?usp=sharing

To Reproduce
Steps to reproduce the behavior:

1. Download PNGs from the GDrive links above
2. Drag/Drop into A1111's "PNG Info" tab and notice all PNG info is displayed w/o error
3. Drag/Drop same PNG into Metaparser and notice "Error Reading File" message
4. Repeat w/ PNGs uploaded to GDrive that work in Metaparser and compare metadate between working & not working. Appears the line added for settings related to "Dynamic Thresholding" extension break Metaparser's functionality. The "Dynamic Thresholding" extension can be downloaded off the A1111 list the extension or this is the link to the repo: https://github.com/mcmonkeyprojects/sd-dynamic-thresholding
5. The line "Dynamic Thresholding" adds to the PNG metadata is bolded here (from one of the included PNGs):

"Lost in the stillness, I search for a sign of life in the silence that surrounds me(" hyperrealism:0.76), cinematic lighting, volumetric light, detailed textures, 4k, unreal engine 5, cinematic, topnotch artstyle, [ IBM PC|Microsoft Windows 95|redshift|hyper-realism render] cgsociety mucha, alphonse and rutkowski greg and artgerm by art illustration, focus, sharp smooth, art
Steps: 52, Sampler: Euler a, CFG scale: 20, Seed: 2135717810, Size: 512x640, Model hash: 46265dcd64, Model: 2023-04-14 - Topnotch EyeDocDay - 42img - 5000 steps, Denoising strength: 0.15, Hires upscale: 1.4, Hires upscaler: 4x_foolhardy_Remacri, Dynamic thresholding enabled: True, Mimic scale: 6, Threshold percentile: 99.05, Mimic mode: Cosine Up, Mimic scale minimum: 3.5, CFG mode: Cosine Up, CFG scale minimum: 3.5
Template: topnotch-gpt3.5, [ 1980s-technology|1990s-technology|render-engine|render]

Expected behavior
PNGs that open properly in A1111's "PNG Info" should open properly in Metparser

Screenshots
See attached PNGs

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrome

Additional context
Related to this as an "Enhancement Request" would be adding support to for "Template " data that can be added to PNG metadata by the popular extension "Dynamic Prompts": https://github.com/adieyal/sd-dynamic-prompts

The "Template" info is an exact copy of the prompt before wildcards/dynamic prompts are selected and replaced in the prompt. There is an option in A1111's settings for that extension called: "Save template to metadata: Write prompt template into the PNG metadata". It's very helpful to be able to reproduce the exact original prompt (including wildcards used not just the one that was selected randomly that time). All of the images I linked above were generated with random wildcards.

Of note, the metadata that "Dynamic Prompts" adds to PNGs does not seem to break Metaparser's ability to read the PNG as the metadata added for "Dynamic Thresholding" does.

Thanks if you can look into this issue and perhaps resolve it in the future! I only just heard about your repo, but it will be extremely helpful if it can handle all of the images I generate w/ A1111 regardless of extensions. I was brought to your repo after reading a discussion on reddit today: https://old.reddit.com/r/StableDiffusion/comments/12md6kc/is_there_a_simple_apprepoetc_that_will_add_a/

Thanks again for you time and effort on this tool!!

Describe the bug
The "To run this application, you must install .NET" prompt appears every time, but when I press Yes, nothing happens.

This is on a Windows 11 machine, with .NET core up to v7.0 installed.

To Reproduce
Win 11. Run MetaParser.exe

Expected behavior
Automated installation of a .NET component? Or the program opens?

Thanks for any ideas.

Describe the bug
The "To run this application, you must install .NET" prompt appears every time I try to fire up the app, but when I press Yes, nothing happens.

This is on a Windows 11 machine, with .NET core up to v7.0 installed.

To Reproduce
Using Windows 11, run MetaParser.exe

Expected behavior
Automated installation of a .NET component and/or the program runs

Thanks for any ideas.