statworx / helfrlein Goto Github PK

adding unit-tests for dive

Wir sollten versuchen möglichst viele Dependencies loszuwerden. Bei manchen geht es schwer, aber darin liegt dann die Herrausforderung ;)

Ist aber nicht für die erste Version nötig!

Adding unit-tests for all functions:

• clean_gc
• dive
• get_network
• multiplot
• get_sequence
• intersect2
• na_omitlist
• print_fs
• strsplit
• to_na

Also adding new functions to this list!

es stimmt noch was nicht mit der library igraph.
hier kommt bei mir selbst beim normalen install.packages("igraph") folgender Fehler:

> library(igraph) Error: package or namespace load failed for ‘igraph’ in get(Info[i, 1], envir = env): lazy-load database '/Library/Frameworks/R.framework/Versions/3.4/Resources/library/igraph/R/igraph.rdb' is corrupt In addition: Warning messages: 1: package ‘igraph’ was built under R version 3.4.4 2: In get(Info[i, 1], envir = env) : internal error -3 in R_decompress1

add unit-tests for get_network

This is not yet implemented, since wihtin the function we use perl = TRUE and fixed = TRUEoverrides this.

When a function is defined twice with different content, in differently named files, it seems, that

ideas:

• choose root functions for network
• funciton with "(" ; ",", ")" check. (sapply, prints, ... )

Tasks

• check dependencies
• check format of functions ( "_" not "." in names)
• check manual pdf
• check usage of package

Dear STATWORX-team,

unfortunately in the newer releases the percent.max parameter is missing in the statusbar() function. It is replaced by width.

In terms of downward compatibility of scripts it would be nice to leave percent.max as redundant parameter inside the function.

thanks
Stephan

update the roxygen comments for the following functions:

• to_na.R
• resave.unique.R
• transform.chr.R

Here are the TODOs before / while going from private to public:

• change structure of package to first level
• building and testing
• add hex
• update README.md with a part of how to install it
• add CI

I have a function called glob_search that searches for a string in all files in a directory and returns those filenames

add unit-tests for multiplot

Hex-Vektor an continous STATWORX Farben

colourCount <- 20
getPalette <- colorRampPalette(as.vector(sci_palette(9))[c(1,2,3,5)])

# within ggplot
ggplot(data.frame(x =  1:colourCount, y = 1), aes(x = x, y = y)) +
  geom_point(aes(size = 5, color = as.factor(x)))  +
  scale_color_manual(values = getPalette(colourCount)[sample((colourCount))]) 

add unit-tests for burglr

@MartAlbers
within the functions sci_palette the format needs to be adjustetd, so that the following error will not occour:

Found the following files with non-ASCII characters:
  sci_palette.R
  show_sci_palette.R

• and please change the names into englisch: no ß ;)
• also it may be a good idea to remove the show_sci_palette function and implement a printmethod instead. @andrebleier can help here I think.

In the process of manually reinstalling packages (igraph) for ubuntu, the R version changes.
Before also stringi caused problems, but got removed with this commit.

might be good to check this one out:
https://github.com/sonatype-nexus-community/oysteR

First of all, THANKS for your time and efforts in producing such a nice package.
If you want to install helfRlein on Windows OS you often run into an install error.

On some installation instances the installation worked with a warning.

Warning: unable to re-encode 'char_replace.R' lines 79, 80

But on others it resulted in an error and I was not able to install it, not with binaries and not by using install_github.

Editing char_replace.R and remove line 79, 80 for installation on windows solved that issue.

Do you have a better workaround?

please add tests for the following cases:

• stopifnot character
• is_found is empty (can that happen?) or NA, integer(0), ...
• add test for example output (for example check for get_filesand the output.

Some other questions I had:

• Please add an example within the documentation. See print_fswith dir = "."
• Please add ::notation to the functions, so that it is easier to see where it comes from. (erum Workshop 😉 )
• Is it necessary to have full.names = TRUE? Is the ralative path from dir not enough?
• if you dont want to remove the dependencies, please add them in the DESCRIPTION file