stdarg / is2 Goto Github PK

Need to root cause.

Fix this.

is.fun(() => {}) //true
is.fun(async () => {}) //false

Because toString.call(async () => {}) === '[object AsyncFunction] '

I don't know how you want to handle this, an async function is a function, so you could just return true, or you may want to distinguish between an async function and a non-async function.

How can I check whether it is a credit card or a debit card

If you are interested, I can submit a PR with the correct file to do automatic builds with travis?

Hi Edmond.

See junosuarez/objectid#8

If that isn't fixed, I wonder if its possible to rework this to not depend on compiled modules?

Its great to have a good quality set of checks on types and not have to write them ourselves, but getting a binary dep just for is2.positiveInt() isn't worth it for us.

It looks like your only use of objectid is to call isValid(), would you take a PR to inline https://github.com/jden/objectid/blob/master/index.js#L7-L10 rather than having to depend on objectid, and through it, the old, compiled, version of bson?