ste7en / ing-sw-2019-chiappalupi-formicola-iannucci

🕹 Software Engineering 1 Project - BSc Thesis

Hey, I'm Stefano 👋

About Me

• 🧑‍💻 I'm a Software Engineer and UX Engineer, graduated in Human-Computer Interaction and Design, with a Double Degree (2021) sponsored by EIT Digital at Politecnico di Milano🇮🇹 and KTH Royal Institute of Technology🇸🇪.
• 👯 I love to collaborate on cool projects with startups
• 🎓 BSc in Engineering of Computing Systems at Politecnico di Milano (2019)
• 📱 iOS Developer at Apple Developer Academy (2018)
• 💬 Ask me about my friendship with Steve Wozniak!
• 💼 Old portfolio available here

Tech Stack

GitHub Stats

Contact Me

ing-sw-2019-chiappalupi-formicola-iannucci's Issues

Update readme

Since deadline is near, we need you to update your readme, by adding the procedure for launching your project. This is must be very detailed (step-by-step).
Also, you need to declare the functionalities you implemented by updating the functionality table: if a functionality was not completely implemented you can leave it yellow, but it will be considered as it was red (that means 0 points); of course, don't try to cheat: we'll deeply test every green functionality.
It's important that everything is up-to-date before the deadline, because we'll clone every repository at midnight and we'll use that version for tests and final review.

UML problems

I have reviewed your UML diagrams.

• There are many enums, such as EffectType, WeaponType and PowerupType, that are used actually as "type". This doesn't follow the OOP principles. If a label is used to distinguish among different behaviors in the code (maybe through a switch), could mean that a hierarchical structure is missing in the design.
• From the design, it's not so clear how you tackle targets in weapons. How can a player choose other ones and shoot them? i feel some logic is missing, as I see mainly getters and setters.
• Add cardinalities to relations, compositions, ....

Please fix these problems ASAP.

Build failure

There is a compile error:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /var/jenkins_home/workspace/AM19/src/main/java/it/polimi/ingsw/utility/Loggable.java:[27,32] private interface methods are not supported in -source 8
  (use -source 9 or higher to enable private interface methods)
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.028 s
[INFO] Finished at: 2019-05-07T21:40:22Z
[INFO] ------------------------------------------------------------------------

Also configure the code coverage with jacoco 0.8.3 (read previous emails).

[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.1:prepare-agent (default-cli) @ AM019 ---
[INFO] argLine set to -javaagent:/var/jenkins_home/.m2/repository/org/jacoco/org.jacoco.agent/0.8.1/org.jacoco.agent-0.8.1-runtime.jar=destfile=/var/jenkins_home/workspace/AM19/target/jacoco.exec
[INFO] 

Please fix asap

Last commit 8 days ago

Are you still working on the project? I see that your last commit is 8 days ago: deadline is near and you should be working hard. From your readme I can see that you're still working on rules, rmi, cli, gui and 2 AF. Is that right?

JAr crashes

1. you have and absolute path. on my computer is different,
2. I changed path to correct JAVAFX lib BUT I get errors

(think about You are delivering a product to a NON - expert customer... is this acceptable?)

java -jar --module-path ./javafx/lib/ --add-modules=javafx.controls,javafx.base,javafx.graphics Adrenaline-GUI-AM19.jar

my layout:

or I am missing something other?