stef / klutshnik Goto Github PK

My compiler doesn't like this line:

https://github.com/stef/klutshnik/blob/master/noise.c#L233

noise.c:233:12: error: implicit declaration of function ‘open’; did you mean ‘popen’? [-Werror=implicit-function-declaration]
  233 |   int fd = open(path,'r');

I think this is a result if mixed up use of the open() and fopen() calls: the character 'r' has some bits set that makes fcntl2's open() implementation assume that the file is going to be created so it expects a third parameter for umask.

I think the second parameter here should be O_RDONLY or fopen() should be used.

their acceptance greatly impacts the security of the whole system, eliminate them.

Lin 65 reports that authtok is not set while it only checks for opaque-store:

instead of duplicating one HMAC key across all kms', use frost to mint new macaroons.

Hi,
I really like this project.

One question:
Normally you calculate the file key for symmetric encryption e.g. with Hash(shared_key || publickey_A || publickey_B) or you use HKDF() instead of Hash().
You only use Hash(shared_key) here (https://github.com/stef/klutshnik/blob/master/common.c#L45), because publickey_A and publickey_B change during a key rotation and you would get a different file key for the symmetric encryption.
Would it make sense to choose a fixed nonce for each file and calculate the file key with Hash(shared_key || nonce) or HDKF(ikm = shared_key, salt = nonce, info = "info") to get a bit more "randomness"?
(Similar to how the payload key is calculated in age https://github.com/C2SP/C2SP/blob/main/age.md#payload)