GithubHelp home page GithubHelp logo

libsodium version checking ? about pysodium HOT 6 CLOSED

stef avatar stef commented on September 25, 2024
libsodium version checking ?

from pysodium.

Comments (6)

stef avatar stef commented on September 25, 2024

damn. sorry man. sure, i think 2 is easier, but 1 is more informative for any user. do you have any of this ready? i was also thinking of putting the aead functions in a try except block, also a very cheap solution, which fails silently, which might not be a good idea again.

from pysodium.

evadot avatar evadot commented on September 25, 2024

The problem for solution 2 is that we also need to check the lib version in the helper function.
An easy way is to have a "function" -> "libsodium version" relation table, which could be useful but also a pita to maintain.
Putting everything in a try/except block will work be I don't think this is a good solution.
The solution 1 I proposed it the simplest, right now for my app I've simply set pysodium==0.6.8 in my setup.py requires, it's just a matter of what you want to do, if you say clearly on the readme.md that you will closely follow the release of libsodium and update as soon as possible pysodium for it it's good for me (and I think for everyone else). It's really easy with pip to track a specific version (as long as you don't delete them).

I don't have any of the code ready (I don't like to do stuff for nothing :P) but as said before I'll provide any code you want based the decision you made.

P.S. : don't feel sorry for me all the problems happened in dev on my machine and not in production :)

from pysodium.

stef avatar stef commented on September 25, 2024

it seems that this patch fails for py3. can anyone who cares about py3 please have a look? thx. failing tests: https://travis-ci.org/stef/pysodium/jobs/134765723

from pysodium.

evadot avatar evadot commented on September 25, 2024

This is weird because I only dev under python3.4, I'll look further.

from pysodium.

evadot avatar evadot commented on September 25, 2024

Ok I wasn't in my venv when testing so I was using python2 ...
Let me fix this quick

from pysodium.

stef avatar stef commented on September 25, 2024

py3 is fixed with d6b96d7

from pysodium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.