Comments (6)
damn. sorry man. sure, i think 2 is easier, but 1 is more informative for any user. do you have any of this ready? i was also thinking of putting the aead functions in a try except block, also a very cheap solution, which fails silently, which might not be a good idea again.
from pysodium.
The problem for solution 2 is that we also need to check the lib version in the helper function.
An easy way is to have a "function" -> "libsodium version" relation table, which could be useful but also a pita to maintain.
Putting everything in a try/except block will work be I don't think this is a good solution.
The solution 1 I proposed it the simplest, right now for my app I've simply set pysodium==0.6.8 in my setup.py requires, it's just a matter of what you want to do, if you say clearly on the readme.md that you will closely follow the release of libsodium and update as soon as possible pysodium for it it's good for me (and I think for everyone else). It's really easy with pip to track a specific version (as long as you don't delete them).
I don't have any of the code ready (I don't like to do stuff for nothing :P) but as said before I'll provide any code you want based the decision you made.
P.S. : don't feel sorry for me all the problems happened in dev on my machine and not in production :)
from pysodium.
it seems that this patch fails for py3. can anyone who cares about py3 please have a look? thx. failing tests: https://travis-ci.org/stef/pysodium/jobs/134765723
from pysodium.
This is weird because I only dev under python3.4, I'll look further.
from pysodium.
Ok I wasn't in my venv when testing so I was using python2 ...
Let me fix this quick
from pysodium.
py3 is fixed with d6b96d7
from pysodium.
Related Issues (20)
- New release for crypto_stream_xchacha20_xor support HOT 2
- crypto_generichash ValueError HOT 2
- crypto_secretbox_open_easy is missing HOT 1
- value of crypto_secretstream_xchacha20poly1305_MESSAGEBYTES_MAX bigger than it should be HOT 3
- ability to check version of pysodium in-code missing HOT 2
- cant find libsodium.dll on windows HOT 6
- Stale Python Pakcage index (2016-06-02) HOT 1
- Harmonize the interface of crypto_aead_chacha20poly1305_* HOT 1
- Inconsistent copyright for test/ HOT 2
- test_crypto_generichash fails with libsodium 1.0.13 HOT 14
- crypto_secretstream* functions? HOT 92
- Input range checking HOT 39
- crypto_aead _NPUBBYTES vs. _NONCEBYTES HOT 8
- Newly added functions lack version checks HOT 6
- PyPi version number not compliant with PEP 0440? HOT 4
- crypto_auth and crypto_auth_verify use empty byte string as a key by default HOT 1
- py3 strings f*ck up generichash HOT 1
- how to use a specific algorithm HOT 7
- crypto_secretbox_detached and crypto_secretbox_open_detached HOT 6
- Expose remaining crypto_core_ ristretto crypto_core_ristretto255_add and crypto_core_ristretto255_sub HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pysodium.