stefankuijers / live-templates Goto Github PK

As mentioned in issue #1 the routerURL detection is not very strong.
issue #1 suggests to make the regex stronger which is a good goal but a maybe that should only be used as fallback of a better way to get the templateURLs which I will suggest in this issue.

Currently after getting all the JS and CSS the live-template.js code set's out another AJAX call to fetch the apps router a second time. The question is; why fetch a second time? It's already there.

After all is done loading we can simply detect which MV* framework is used and based on that retrieve the templateURLs through the app.router object. No fragile algorithm.

I'm not sure how easy this is as everybody can build their app the way they want... I could be this is a solution that is way more robust than a regex.

If the routerURL is wrong and/or the ajax call returns empty live reload does not start.

For the code to work you have to specify the router url.
https://github.com/stefanKuijers/live-templates/blob/master/live-templates.js#L32

Could make this optional by checking for one time all the urls at initialization and searching for a file that looks like it has a router in it.
router.js app.js routes.js

Currently the templateURL detection regex is not very strong. It has the following weaknesses:

• urls that are commented out will still be recognized
• not only template urls but orther links or urls will match aswell

It will not match on the following cases:

• any url with an : so http(s)
• if the file-extension is not .html or .jade

Current regex:
/[a-zA-Z0-9-./][a-zA-Z0-9-.]+.(html|jade)(/\S)?/g;
https://github.com/stefanKuijers/live-templates/blob/master/live-templates.js#L30

To make this algorithm stronger it could:

• ignore commented lines
• look for string in single or double qoutes
• url should be preceded by templateURL|url|template and :

Can as well be extended to support more template extensions