GithubHelp home page GithubHelp logo

Comments (3)

urugator avatar urugator commented on May 12, 2024

If I read the sources correctly, parsers like nullable/union try to simplify the output whenever the inner types are primitive, but the inner type in this case is optional and the algo doesn't try to look further at it's inner type...

OT: any reason why this check:

["ZodString", "ZodNumber", "ZodBigInt", "ZodBoolean", "ZodNull"].includes(
def.innerType._def.typeName
) &&

doesn't use in primitiveMappings like here:
https://github.com/StefanTerdell/zod-to-json-schema/blob/master/src/parsers/union.ts#L51
??

from zod-to-json-schema.

urugator avatar urugator commented on May 12, 2024

The application order in case of nullish was actually already fixed in zod, but it's not released yet:
colinhacks/zod@0c0e495

from zod-to-json-schema.

StefanTerdell avatar StefanTerdell commented on May 12, 2024

Closing this since Zod is a peer dependency and this can be fixed by just bumping it.

from zod-to-json-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.