stellar-group / miniapps

This repository holds a collection of mini applications from various sources ported to HPX.

HPX MiniApps

This repository holds a collection of mini applications from various sources ported to HPX.

miniapps's Issues

HPX API changes break MiniGhost

moving the issue STEllAR-GROUP/hpx#1806 to the correct repository

---

While looking through the ported MiniGhost app, I began updating the code and fixing errors caused by old API calls that were either removed or changed. I've reached a point however that I don't know how to get past, in MiniGhost global_sum.hpp l39 the code block reads:

if(this != &other) {
    mtx_        = std::move(other.mtx_);           // breaking change
    value_      = std::move(other.value_);
    generation_ = other.generation_;
    gate_       = std::move(other.gate_);
}
return *this;

In this context, mtx_ is a hpx::lcos::local::spinlock. Previously spinlock was movable but not copyable here and also implemented the operator =. A commit on may 19th changed spinlock significantly, breaking MiniGhost. The the new version of spinlock, operator= no longer eixsts and it not movable at all source

To fix MiniGhost, how would I now perform the operation on line 39? Is it possible to do this anymore?