stenington / badgecub Goto Github PK

We could provide a default badge image for those who want to badge without art, although I wonder if that will conceal the fact that you can (and perhaps should) make badge art of your own!

light and semibold as per the designs

Right now badgecub supports a single global criteria page, which could at least look nicer and say something meaningful, if generic.

Instead of "someone sent you"...

I'm unclear if the "message" field in the form is just text to add to the email, or if it is intended to become an evidence page (hence the ask for links).

The image is slow to load which I'm not 100% sure we can get around (or rather I'd tackle that in a separate ticket) but we could specify a size, which would at least reserve the space and make it look less broken I think.

Text tweaks are being discussed in #2.

The email could generally use some more color as in the designs, and have the logo etc.

It can get cut off. not sure what the rights solution is.

Image type should be png.

The quickest solution is to add accept="image/png" to the file input, although we may also want more validation or even conversion at some point to handle a wider variety of cases.

We're not hashing emails in the badge, and we should be.

Buttons are the default foundation style right now. Make them look like the ones in the mockups!

Error: Unknown/unhandled image type

Please feel free to provide more context about what you were doing when the error occurred.

Hey tried putting in a .gif and a .jpg and got this error. Made this badger very sad that she could not send her happy little badge.

Thanks!

The default form error styles are jarring:

I think they could look a little less intimidating (and of course the wording might need to be tweaked).

Maybe they should be allowed?

it's driving me nuts!

When a person gets an email with a badge, it would be nice to have clear next steps explaining what you can do from there. An obvious thing is getting the badge into your Backpack which can be done currently via file upload, or we could add a helper page that invokes the Issuer API and provide a link to that if desired.

We could consider this... although it is intended for a fairly limited issuing use case so it might not make sense.

Static assets could actually be hosted on s3, including the compiled css, issuer.json, criteria page, and other basic pages. It might be nice to have a build step compile those things and dump them in a /dist directory or whatever.

Add in the landing page

And make that url the issuer instead of the AWS url.

so it explains a little bit more about what is a badge etc.

Short term this could just be a name, although of course that's open to abuse.

Slightly more advanced is a name and required email address, so the recipient has a way of contacting the sender if necessary. Of course that's still open to some abuse, but you'd have means of investigating it.

And ultimately we could add login which could then auto-populate those fields, potentially.

like @carlacasilli did :(

Error: Unknown/unhandled image type

I uploaded the image below. It showed in the preview just fine. But I got an error when I tried to give. Maybe it's just too big? 2mb.

BTW ... this error handling and reporting is super pleasant.

like p2pu does http://badges.p2pu.org/en/badge/view/420/