Comments (57)
- Also, please use one of the logo2.svg/png files in place of "Redwood EDA" in the footer, sized/positioned appropriately.
from warp-v.
- Please add to the generated config file:
\m4_TLV_version 1d: tl-x.org
\SV
/*
Copyright <YEAR> Redwood EDA
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
- Fill in the year based on the current date.
from warp-v.
- "Custom" -> "Custom Pipeline" (just to make the connection with the "Pipeline" tab)
from warp-v.
A few more:
- Please switch from:
m4+module_def
\TLV
m4+warpv_makerchip_cnt10_tb()
m4+warpv()
m4+makerchip_pass_fail()
\SV
endmodule
to
m4+module_def
\TLV
m4+warpv_top()
\SV
endmodule
- Please change back to
M4_NUM_CORES
. My bad. - I had sent a sandbox w/ improved formatting. Use that.
from warp-v.
- Under "Verilog" tab, also add
--noline
to the list of args, and select it by default. Descrption: "Disable `line directive in SV output.". - Visual indication of which version of the model is selected. Maybe shading on the rounded rectangle.
from warp-v.
- There no file to open/download when the configuration GUI is the selected type. Let's just eliminate that as a selection, and make the config file the default.
from warp-v.
- Let's add this to Verilog flags as well:
--fmtNoSource: Do not generate \source tags for correlating pre- and post-M4 code.
, and enable by default.
from warp-v.
- It looks like
EXTRA_NON_PIPELINED_BUBBLE
andEXTRA_TRAP_BUBBLE
should default to1
. - At one point I had changed the default of EXT_M and EXT_E to 0. It looks like they are not defined if they are 1, and are therefore always 0 now. It's reasonable to always define all EXT_*.
from warp-v.
This one is popping up again:
- Include statements must be modified:
Must become:
`include "./sv_url_inc/picorv32_pcpi_div.sv" // From: "https://raw.githubusercontent.com/stevehoover/warp-v_includes/master/divmul/picorv32_pcpi_div.sv"
Specifically, this should be applied to the .tlv and .sv files when opened in Makerchip.m4_sv_include_url(['https://raw.githubusercontent.com/stevehoover/warp-v_includes/master/divmul/picorv32_pcpi_div.sv'])
- Also, we'll have to change the
\TLV_version [\source test.tlv] 1d: tl-x.org
line of the.tlv
file to\m4_TLV_version ...
You can test these with EXT_F == 1.
from warp-v.
- For EXT_F == 1, we need to add this above the
m4_include_lib
line:/* verilator lint_off WIDTH */
- For EXT_M == 1,
/* verilator lint_off WIDTH */ /* verilator lint_off CASEINCOMPLETE */
- EXT_B needs:
/* verilator lint_off WIDTH */ /* verilator lint_off PINMISSING */ /* verilator lint_off SELRANGE */
(And when multiple are selected, the superset of waivers is needed.)
from warp-v.
Does this mean EXT_E and EXT_M are always 0, or that if they are 1 they should not be included in the TL-V config
from warp-v.
I'm suggesting to always include them in the TLV. They default (now) to 0 and could be omitted, but, I'd say, always include them explicitly.
from warp-v.
Notice that I had unchecked "LD_RETURN_ALIGN is different. It must be >= (EXECUTE_STAGE - NEXT_PC_STAGE)" above.
- Let's use the default test program unless the user chooses to customize it. This way we will get a different test program depending on the selected options by default.
from warp-v.
- You can remove:
// -------------------------------------------------------
// Here you can provide your own assembly program that
// will be hardcoded into the instruction memory of your core.
// The syntax roughly mimics that defined by the RISC-V ISA,
// but not exactly.
// -------------------------------------------------------
(since you have it elsewhere)
from warp-v.
- For most of the "Verilog" flags, rather than specifying them on the command line, you can specify them in the source file, e.g.:
\m4_TLV_version 1d --fmtXXX --fmtYYY: tl-x.org
This way, when the source or .tlv is opened in Makerchip, the args will take effect.
I think the only arg that must be on the command line is --fmtNoSource
.
from warp-v.
Ready to test again!
from warp-v.
- For MIPS, we should disable:
- the use of a custom test program,
- all ISA extensions. (There is a comment "RISC-V only", but I see that these report a fatal error if selected.)
- multiple cores.
- Use
m4+warpv_top()
always, not just for custom test program. - I've unchecked "Include statements must be modified" item above, as it doesn't seem to be working.
from warp-v.
Include statements were modified on open in Makerchip, but that was not displayed in the file box. Fixed!
from warp-v.
Made updates
from warp-v.
Did you check include statements by opening TLV file (after M4) w/ F-type in Makerchip? That was the problematic case. I can't test it at the moment.
from warp-v.
@stevehoover this is a success, right? https://makerchip.com/sandbox/0v2fWhogD/076hzqz#
Ready for review
from warp-v.
This is a failure, but not a configurator issue. WARP-V is built for SystemVerilog. It looks like you probably checked to build as Verilog. So this is a WARP-V issue. We could remove the Verilog option for now, but let's just leave it and accept the failure.
from warp-v.
Ok! Are there any other issues that you found?
from warp-v.
- Don't touch this one:
I think this is from the header file and probably has a different comment than the others.
m4_sv_include_url(['sandpiper_gen.vh']) // Originally: `include "sandpiper_gen.vh"
- Look at the include of
picorv32_pcpi_fast_mul
in this sandbox:https://makerchip.com/sandbox/0v2fWhogD/0GZhBgM#
. in both the Editor and Nav-TLV.
from warp-v.
sandpiper_gen.vh isn't touched anymore! What do you mean by the second checkbox?
from warp-v.
-
EXT_B
needsWIDTH
. I've unchecked above.
from warp-v.
- It seems the minimum values for multi-core are:
PRIOS: 2
VCS: 2
PACKET_SIZE: 3
from warp-v.
- To use the arguments specified on the first line of the TLV file, it is necessary to provide SandPiper with the argument
--iArgs
. (This one had me scratching my head for a while.)
from warp-v.
- Create and add a WARP-V favicon.
from warp-v.
- While debugging failing configs, I've discovered a bug in the
--fmtStripUniquifiers
flag, so please remove that one for now. (Comment it out in your code with aTODO
to add it back whenmono
Issue #433 is closed.
from warp-v.
warp-v.org is updated again
from warp-v.
Looking pretty solid!
- If you enable a custom program, then select MIPS, then RISC-V again, the custom program is not editable until you uncheck and re-check "Enable custom program".
- "Verilog" and "Program" overflow their box. A few options:
- Expand the space.
- Add scrolling or wrapping.
- (For now) remove "Memory" and "I/O". They are nice to have just to show that we are not ignoring the fact that we don't address them, but they don't actually do anything.
- Merge "Hazards" back into "Pipeline" (with a "Hazards" heading).
Thoughts? I'd say maybe merge "Hazards" and extend the size as needed.
from warp-v.
- If no command-line args are selected, there is a space after
1d
and before the:
that results in a parsing error.
from warp-v.
- Let's add an option for the warp-v version as a full URL. Also have buttons to fill in the URL field with the latest version (
master
) or the latest known-good version (<sha>
) (and this will be the default). This will help to keep the configurator stable until we have regression testing, and it will be useful for manual testing of master. For lack of a better place, maybe put this under "Verilog". This URL would be used for:m4_include_lib(['https://raw.githubusercontent.com/stevehoover/warp-v/master/warp-v.tlv'])
.
from warp-v.
I'm going to extend the table size first, let me know if it looks too weird.
from warp-v.
In the future, it would be helpful to debounce inputs. I'm trialing it with the warp-v version input, and it's working very well
from warp-v.
@stevehoover addressed all requests
from warp-v.
In the future, it would be helpful to debounce inputs. I'm trialing it with the warp-v version input, and it's working very well
I don't follow. You're referring to the WARP-V version? Yeah, looks great! Though,
- "Override" could be deleted, and maybe "tested" rather than "supported"? edit: Oh, and let's say "latest" rather than "master", since master is the whole branch, not a version.
- The configuration panel is okay, but it's a little wonky. It follows a different sizing policy than the other components. Ideally it should be consistent with "Get your code" and "Core details". (You can remove the ":" from "Get your code:" for consistency.) And the container size adjusts to the window, but the headings overflow. Not the end of the world, but think about any easy fixes.
from warp-v.
- It looks like when "Do not generate \source tags ..." is deselected, a source tag exists in the 1st line of the TLV file, e.g.
\TLV_version [\source test.tlv] 1d
. I'm not sure why, but this seems to fail in Makerchip. It is safe to remove[\source test.tlv]
. Ah... this happened because we modify\TLV_version
to\m4_TLV_version
to be able to utilize M4 for file imports. So, yeah, delete the source tag, too, if present.
from warp-v.
I've tracked down a Verilator bug. It surfaces for the --fmtPackAll
option. We can work around it with /* verilator lint_on WIDTH */
. So:
- Add
/* verilator lint_on WIDTH */
for--fmtPackAll
, and comment the code with:// TODO: Disabling WIDTH to work around what we think is
https://github.com/verilator/verilator/issues/1613`. This can be removed once the bug is resolved and deployed in Makerchip.`
from warp-v.
updated!
from warp-v.
TLV parsing is picky. You'll need to remove the extra space when removing [\source test.tlv]
. Unchecked above.
from warp-v.
- We'll need an approach to address the pop-up blocker. Maybe if we host as warp-v.makerchip.com we can avoid it?? Is there a way to detect it, and notify??
from warp-v.
What do you mean, pop-ups? I don't think I've ever gotten a pop-up notification
from warp-v.
It's possible that instead of opening a new tab we could just redirect the user in the current window, but I'm not sure that would work either
from warp-v.
I think I had to unblock pop-ups the first time and forgot about it thereafter. Maybe you did the same? I was showing to someone else on their system over zoom and noticed it was blocked from opening a new tab.
from warp-v.
BTW, I'm trying to resolve failures for Verilog output prior to announcing. And we should have some snazzy visualization soon. The Verilog issue is a bit gnarly and failing regression (due to an unrelated package version issue.)
from warp-v.
from warp-v.
- mobile usability
from warp-v.
Definitely a WIP for mobile, but check it out and see how you like the changes so far. Also please check if pop-ups are still there..
from warp-v.
:(. Yep, Firefox blocked me.
from warp-v.
With all this talk of Intel acquiring Si-Five, it's a great time to announce the configurator.
- Something went askew where the 2 core diagrams are stacked rather than side-by-side.
from warp-v.
- We should have a way to report bugs. Let's just change "Dig deeper in the github repository" to "Dig deeper or report bugs in the github repository".
from warp-v.
Mobile looks great. Just some nits to track (nothing blocking announcement):
- There's a "Get started" menu option that does nothing.
- Button text overflows.
from warp-v.
I'll have to look more into shrinking font size on mobile. I might have just found a workaround for popups. Updated the site
from warp-v.
- Update github warp-v SHA to latest.
from warp-v.
Looks like we're done with this one!! If there's anything from here you want to track, file a new issue.
from warp-v.
Related Issues (9)
- Support syntax highlighting and detection of TL-Verilog by GitHub HOT 4
- current state of repo does not reproduce on makerchip HOT 1
- Configurator tweaks
- Configurator: Add support for SandPiper --fmt* options. HOT 2
- Configurator tweaks
- Configurator tweaks
- Configurator config pane sizing HOT 3
- imem produced by sandpiper not supported in either vivado or yosys HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from warp-v.