stevenbenner / grunt-indent Goto Github PK

Would be nice if the plugin could just detect the size and style of indentation automatically.

Hm, I can't get this running properly.

My setup is just like in the docs:

indent: {
      src: ['src/*.js'],
      dest: 'tmp/',
      options: {
        style: 'space',
        size: 2,
        change: 1
      }
    }

when I log dest in https://github.com/stevenbenner/grunt-indent/blob/master/tasks/indent.js#L66 I get src as destination file.

Am I missing something?

Running the task on files with Windows style line endings will cause the indent task to change the indent on empty lines.

It looks like the underscore.string lines() function is splitting on \n only. Since Windows uses \r\n for its line endings the resulting array will contain \r for empty lines, causing the empty string test to return false. This probably means that the lines() function doesn't work at all for Mac OS9 style line endings which are only an \r character.

Desired behavior: Do not modify empty lines.

Right now indent assumes that the dest option is a folder, and will not let users set the destination file name. This should be changed to check if dest is a folder, if it is not a folder then save the result in the exact path that the user specified.

Example:

{
    src: 'path/to/file.js',
    dest: 'path/to/newFile.js'
}

It could be a useful to give people using this task the ability to change the current indentation format when processing a file (e.g. convert spaces to tabs).