Comments (12)
you had an error in the connection internet. if you try it again it will work again. there is no need to change the code for this, this was a real error and not interfacelift downloader.
from interfacelift-downloader.
I use it weekly, never an error, i download serial 1080p, 4k,5k all at once.
from interfacelift-downloader.
it is pretty pointless to report bugs when getting this kind of attitude
from interfacelift-downloader.
you just start the program again and if your internet is stable it will throw no error.
the bug was in the internet not in the program, although you could catch an error and handle it, but people try to work less then more when it still works with a stable internet ...
from interfacelift-downloader.
ECONNRESET error is a very common known error in nodejs.
it means the internet connection was stopped while you were using any/all/this program.
from interfacelift-downloader.
Sorry for the delayed response, somehow I missed this github issue.
I cannot reproduce this problem. Does this happen every time you run the script? If so, does it fail after the same number of files? If you wait a while does it start working again?
I'm thinking that it's either a connectivity issue or you're running into some kind of rate limiting from the web site.
from interfacelift-downloader.
I think your rate limit is scraping slow enough, i never had an ECONNRESET error. Rate limit would give a HTTP 500 status bad gateway.
This was a connection issue.
from interfacelift-downloader.
You can scrape it and during turn off the net. Then you will get this same error.
from interfacelift-downloader.
You could provide a nice error like the internet broken etc.. Etc..
from interfacelift-downloader.
Reopening as a possible improvement.
Yeah it would probably make sense to catch any errors thrown by http.get()
and print out a more user friendly error.
I think some retry logic would be a good addition to handle a randomly dropped connection. If it fails with a connection error then wait a few seconds (probably implement exponential backoff) and retry, repeat up to some limit then fail. This would make it all around more resilient to random failures.
from interfacelift-downloader.
Openwrt download logic is usually 5 retry, 5 sec, 10 sec, 15 sec, 20 sec, 30 sec, then it gives up.
from interfacelift-downloader.
Fixed - or at least improved - in commit 0357eb2e3187525dd3b7e18273d3c7d173ba6131
.
I have added error handling to download operations that will catch connection errors and retry the download after an increasing delay. The retry is limited to 3 attempts, after which it will move on to the next file in the download queue.
This fix is included in the latest 2.4.0 release.
from interfacelift-downloader.
Related Issues (19)
- Script fails in node v0.10.0
- Unsupported Resolutions HOT 2
- Support for 5120x2880 resolution HOT 1
- Issue with running script with 5120x2880 HOT 2
- Support HOT 2
- Newbie question HOT 2
- Add support for iPhone 6 Plus resolution (1242x2208) HOT 2
- This program is aweseome! Keep on it! HOT 1
- Rewrite the script to be NPM installable and usable as a global HOT 1
- Unhandled 'error' event. HOT 1
- Feature request
- Docker support for Unraid HOT 1
- "X" is not a known resolution HOT 3
- Just not working :) HOT 5
- Script hangs randomly HOT 8
- More resolutions! HOT 2
- wrong resolution downloaded HOT 8
- Refactor Downloader() to fix or remove recursion. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from interfacelift-downloader.