steveplays28 / restart-server Goto Github PK

If I use cyrilic letters in config, it shows as CE2BF5-like text

I have a Start.sh file in the root of my server installation that I wish to point to. Unfortunately, it is not specified what the 'origin' of the start script path you specify is. I've tried Start.sh and ../Start.sh to no avail.

[main/WARN]: Reference map 'restart-server-refmap.json' for restart-server.mixins.json could not be read. If this is a development environment you can ignore this message

Small warning, but might be worth looking into sometime.

In 1.20.4 I am able to use the mod, but restarting only works from the console when no players are online. If any player is on it will stop, but then crash. Additionally, issuing /restart from the game doesn't have an effect. It will print in console, but nothing actually happens, which is shown here, followed by a console-issued restart.

[22:44:03] [Server thread/INFO]: [Restart Server] Restarting server...
[22:44:12] [Server thread/INFO]: [Restart Server] Restarting server...
[22:44:12] [Server thread/ERROR]: Encountered an unexpected exception
java.lang.NoSuchMethodError: 'void net.minecraft.server.network.ServerPlayNetworkHandler.method_14367(net.minecraft.text.Text)'
	at io.github.steveplays28.restartserver.commands.RestartCommand.lambda$execute$2(RestartCommand.java:28) ~[restart-server-1.2.0+mc1.19.x-1.20.x.jar:?]
	at java.util.ArrayList.forEach(Unknown Source) ~[?:?]
	at io.github.steveplays28.restartserver.commands.RestartCommand.execute(RestartCommand.java:28) ~[restart-server-1.2.0+mc1.19.x-1.20.x.jar:?]
	at io.github.steveplays28.restartserver.commands.RestartCommand.lambda$register$0(RestartCommand.java:20) ~[restart-server-1.2.0+mc1.19.x-1.20.x.jar:?]
	at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.2.9.jar:?]
	at net.minecraft.command.FixedCommandAction.execute(FixedCommandAction.java:29) ~[server-intermediary.jar:?]
	at net.minecraft.command.FixedCommandAction.execute(FixedCommandAction.java:13) ~[server-intermediary.jar:?]
	at net.minecraft.command.SourcedCommandAction.method_54405(SourcedCommandAction.java:8) ~[server-intermediary.jar:?]
	at net.minecraft.command.CommandQueueEntry.execute(CommandQueueEntry.java:8) ~[server-intermediary.jar:?]
	at net.minecraft.command.CommandExecutionContext.run(CommandExecutionContext.java:107) ~[server-intermediary.jar:?]
	at net.minecraft.server.command.CommandManager.callWithContext(CommandManager.java:378) ~[server-intermediary.jar:?]
	at net.minecraft.server.command.CommandManager.execute(CommandManager.java:308) ~[server-intermediary.jar:?]
	at net.minecraft.server.command.CommandManager.executeWithPrefix(CommandManager.java:298) ~[server-intermediary.jar:?]
	at net.minecraft.server.dedicated.MinecraftDedicatedServer.executeQueuedCommands(MinecraftDedicatedServer.java:299) ~[server-intermediary.jar:?]
	at net.minecraft.server.dedicated.MinecraftDedicatedServer.tickWorlds(MinecraftDedicatedServer.java:284) ~[server-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:845) ~[server-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:683) ~[server-intermediary.jar:?]
	at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:270) ~[server-intermediary.jar:?]
	at java.lang.Thread.run(Unknown Source) ~[?:?]
[22:44:12] [Server thread/ERROR]: This crash report has been saved to: C:\Users\userpathhere
[22:44:12] [Server thread/INFO]: BlueMap unloaded!
[22:44:12] [Server thread/INFO]: Safely shutdown!
[22:44:12] [Server thread/INFO]: Shutting down Geyser.
[22:44:13] [Server thread/INFO]: Geyser shutdown successfully.
[22:44:13] [WebSocketConnectReadThread-95/INFO]: The skin uploader has been closed
[22:44:15] [Server thread/INFO]: Stopping server
[22:44:15] [Server thread/INFO]: Saving players
[22:44:15] [Server thread/INFO]: foobar lost connection: Server closed
[22:44:15] [Server thread/INFO]: foobar left the game
[22:44:15] [Server thread/INFO]: Saving worlds
[22:44:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Build Test]'/minecraft:overworld
[22:44:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Build Test]'/minecraft:the_end
[22:44:15] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Build Test]'/minecraft:the_nether
[22:44:15] [Server thread/INFO]: ThreadedAnvilChunkStorage (superflat): All chunks are saved
[22:44:15] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[22:44:15] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[22:44:15] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[22:45:15] [Server Watchdog/ERROR]: A single server tick took 60.00 seconds (should be max 0.05)
[22:45:15] [Server Watchdog/ERROR]: Considering it to be crashed, server will forcibly shutdown.
[22:45:15] [Server Watchdog/ERROR]: This crash report has been saved to: C:\Users\userpathhere

Add a config option to just run /stop instead of specifying a file name for scripts such as the autorestart script from https://startmc.sh/
While this wouldn't be any different than running /stop for manual restarts, it would work for scheduled restarts

I want to give permission to restart the server to moderators, but it seems like this mod doesn't support it. It isn't shown by autocomplete in luckperms' web editor.


I tried to write something like "restartserver.commands.restart" manually, but it doesn't work.

As an example of mod which support privileges:
https://github.com/Patbox/ArmorStandEditor/blob/1.20/src/main/java/eu/pb4/armorstandeditor/util/GeneralCommands.java

In my specific scenario, I use Byobu for creating new windows in the terminal to run the server in. However, upon restart, the new window is created before the old window actually has a chance to finish up and close, which unnecessarily increments the window number. Whilst superficial, it would be nice to fix this.

I imagine some fix is possible if we could better define at which part of the process certain scripts run.

Also just having a config option to determine whether the mod waits for the server to entirely close/finish up or not before running the start script would be great.

Releases of the mod say it works on 1.18.x and 1.19.x and so does fabric.mod.json but it just doesn't on 1.18.
I know the README says you won't backport so it'd just be nice if you could remove the apparent support for 1.18.
There's a backport of the dev branch for 1.18.2 on my fork (doesn't work on 1.19), just let me know if you want a PR for it.

I'm not sure why but whenever I try to restart with the command it doesn't work. Heres the log.
[00:50:53] [Server thread/INFO]: �[38;5;11m[Restart Server] Restarting server...�[0m
[00:50:53] [Server thread/INFO]: [Restart Server] java.io.IOException: Cannot run program "cmd": error=2, No such file or directory
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
at java.base/java.lang.Runtime.exec(Runtime.java:594)
at java.base/java.lang.Runtime.exec(Runtime.java:418)
at java.base/java.lang.Runtime.exec(Runtime.java:315)
at io.github.steveplays28.restartserver.commands.RestartCommand.execute(RestartCommand.java:34)
at io.github.steveplays28.restartserver.commands.RestartCommand.lambda$register$0(RestartCommand.java:19)
at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:264)
at net.minecraft.class_2170.method_9249(class_2170.java:287)
at net.minecraft.class_2170.method_44252(class_2170.java:280)
at net.minecraft.class_3176.method_13941(class_3176.java:299)
at net.minecraft.class_3176.method_3813(class_3176.java:284)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.io.IOException: error=2, No such file or directory
at java.base/java.lang.ProcessImpl.forkAndExec(Native Method)
at java.base/java.lang.ProcessImpl.(ProcessImpl.java:314)
at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:244)
at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1110)
... 15 more

[00:50:53] [Server thread/INFO]: �[38;5;9m[Restart Server] Server restart failed.�[0m

I am currently running a Fabric MC 1.19.2 server with a few server + client side mods. When the variable: "restartIfNoPlayersHaveBeenOnline" is set to true, whenever a player attempts to join the server, they are greeted with: "Server is restarting...". This will happen regardless of the time that the variable: "noPlayersWaitTime" is set to. I have reinstalled the config to its defaults, and the server is joinable, but as soon as the "restartIfNoPlayersHaveBeenOnline" variable is set to true, it restarts upon a join attempt.

I have tried to tweak the times and settings for a verity of the scheduled restarts, but none seem to effect it except for the one mentioned above.

Do you happen to have any future updates for 1.20.1?

had a restart scheduled for every 3 hours, it gave me this. sorry for the massive amount of mods, lol
crash-2024-03-15_15.17.17-server.txt

if not would that be possible to implement

The server simply gets opened in the background, instead of in a new terminal window.

Something like this should fix it:
https://stackoverflow.com/questions/11706159/run-an-application-in-a-new-terminal-window-from-a-java-program#11706448
Making this configurable would probably be nice too.

Hello if I type the restart comand in the chat it just kicks me and dosn´t restart but if I do that in the console it works.
Server Version: Fabric 1.19.3
Loder Version: 0.15.9

Log.txt
config.txt

I've seen this feature on some servers before, I guess it would be better if players haven't to reconnect by themselves

I wanted to give the permission for players in my server that I trust and I can't give them op that allows tp and creative mode, I just wanted to give them the control if the server lags

Configurable countdown of the last X seconds before the server actually performs the restart. Seems better than just saying "restarting in ~2m".

Furthermore, instead of a restart message like "restarting in ~2m", it would be better if you could use a placeholder to specify where the total restart grace period is displayed. Something like `"restarting in ~${time}", for a basic example. This would work better alongside the above suggestion of a configurable timer, as the timer message could also be configured dynamically using a similar placeholder.