The stm32f3xx_hal_driver's discuss from stmicroelectronics

stm32f3xx_hal_driver's Issues

LL: OPAMP functional modes assert incomplete

Describe the set-up

custom board, not directly relevant to issue
GCC 10.2, cmake, ninja

Describe the bug
These two functional modes are not allowed by checking macro and causes assertion when used.

Funtional modes:

#define LL_OPAMP_MODE_STANDALONE        (0x00000000U)                               /*!< OPAMP functional mode, OPAMP operation in standalone */
#define LL_OPAMP_MODE_FOLLOWER          (OPAMP_CSR_VMSEL_1 | OPAMP_CSR_VMSEL_0)     /*!< OPAMP functional mode, OPAMP operation in follower */
#define LL_OPAMP_MODE_PGA               (OPAMP_CSR_VMSEL_1)                         /*!< OPAMP functional mode, OPAMP operation in PGA */
#define LL_OPAMP_MODE_PGA_EXT_FILT_IO0  (OPAMP_CSR_PGGAIN_3                      | OPAMP_CSR_VMSEL_1) /*!< OPAMP functional mode, OPAMP operation in PGA with external filtering on OPAMP input IO0. */
#define LL_OPAMP_MODE_PGA_EXT_FILT_IO1  (OPAMP_CSR_PGGAIN_3 | OPAMP_CSR_PGGAIN_2 | OPAMP_CSR_VMSEL_1) /*!< OPAMP functional mode, OPAMP operation in PGA with external filtering on OPAMP input IO1. */

Macro used in assert.

#define IS_LL_OPAMP_FUNCTIONAL_MODE(__FUNCTIONAL_MODE__)                       \
  (   ((__FUNCTIONAL_MODE__) == LL_OPAMP_MODE_STANDALONE)                      \
   || ((__FUNCTIONAL_MODE__) == LL_OPAMP_MODE_FOLLOWER)                        \
   || ((__FUNCTIONAL_MODE__) == LL_OPAMP_MODE_PGA)                             \
  )

Clearly, macro does not accept LL_OPAMP_MODE_PGA_EXT_FILT_IO0 and LL_OPAMP_MODE_PGA_EXT_FILT_IO1 functional modes.

How To Reproduce

have code like

	LL_OPAMP_InitTypeDef OPAMP_InitStruct {};
	
	OPAMP_InitStruct.FunctionalMode = LL_OPAMP_MODE_PGA_EXT_FILT_IO1;
	OPAMP_InitStruct.InputNonInverting = LL_OPAMP_INPUT_NONINVERT_IO0;
	OPAMP_InitStruct.InputInverting = LL_OPAMP_INPUT_INVERT_IO1;
	LL_OPAMP_Init(OPAMP2, &OPAMP_InitStruct);