stokatyan / scrollcounter Goto Github PK

Awesome library. Could definitely put this to use. Do you plan to add support for comma delimiters for thousand, millions, etc.? (e.g 1,000.00 or 1,000,000.00)

It would be nice to have a new init parameter where one could specify how many digits should be grouped together.

Seems like there's an issue when decimalPlaces = 2 (and I think in general regardless of decimalPlaces) 3.89 (or any number ending with 9 after decimal) turns into 3.8 (cutting off or perhaps rounding the last digit?) when calling method func setValue(_ value: Float, animated: Bool = true).

OR when number is 3.199 and decimal places is 3, resulting in displaying 3.1 9, middle number after decimal just disappeared

Greetings!

Attempting to use your cocoa pod. Getting an issue when initializing the NumberScrollCounter. In the public init, you have the line:

frame.size.height = digitScrollers.first!.height

However, the digitScrollers are set as the top as an empty array and never set to a value. So – I am getting an "Thread 1: Fatal error: Unexpectedly found nil while unwrapping an Optional value" error when attempting to use this. Any suggestions?

Here is my call trying to use the NumberScrollCounter:

let label = NumberScrollCounter(value: 0, scrollDuration: 0.33, decimalPlaces: 0, font: UIFont(name: "TitanOne", size: 56)!, textColor: K.Colors.yellow!, animateInitialValue: true, gradientColor: .black, gradientStop: 0.2)

Thanks for a nice component. Unfortunately I doesn't work well when I try to use it right-aligned, due the sizing being incorrect. When adding/removing digits, the size of the whole view isn't updated, at least if the view is positioned using auto-layout.

Please add support of Swift Package Manager (SPM).