React Failed to compile about json-schema-viewer

[Drethic]

After installing mobx, markdown-viewer, and ui-kit the system started work. I also tested with 4.0.0-beta.16 and that fired up without any additional installs.

Thank you for all your help on this. And not to worry about the delay. I saw all the activity to get 4.0.0 out the door and figured this bug would be resolved with that update to limit churn between versions.

[mpodlasin]

Hey @Drethic could you share with us what version of @stoplight/ordered-object-literal package you have in our node_modules? 🤔

[Drethic]

This is from it's package.json:

  "name": "@stoplight/ordered-object-literal",
  "version": "1.0.1",

[mpodlasin]

If you update to 1.0.2 your problem should go away. :)

Let me know how it went.

[Drethic]

I ran yarn upgrade and verified @stoplight/ordered-object-literal incremented to 1.0.2. After starting I am now getting a new compile error:

Failed to compile.

./node_modules/@stoplight/json-schema-viewer/index.es.js
Module not found: Can't resolve '@stoplight/markdown-viewer' in '/path/to/project/schema-viewer/node_modules/@stoplight/json-schema-viewer'

To ensure my node_modules weren't corrupt from the upgrade I removed the whole node_modules directory, reran yarn install, verified ordered-object-literal was still 1.0.2, and after starting the react app the markdown-viewer error was still present.

edit 1:
I checked my node modules and @stoplight/markdown-viewer is not installed. I do see in the json-schema-viewer package.json that markdown-viewer is listed as a peerDependencies. yarn may not be picking up the need to install that with the base install command. I'd have to try with npm to see if I get the same results.

edit 2:
After installing with npm I do get a warning about needing several peer dependancies to include markdown viewer:
npm WARN @stoplight/[email protected] requires a peer of @stoplight/markdown-viewer@^3 but none is installed. You must install peer dependencies yourself.

Here is the full peer dependency message:

npm WARN @stoplight/[email protected] requires a peer of @stoplight/markdown-viewer@^3 but none is installed. You must install peer dependencies yourself.
npm WARN @stoplight/[email protected] requires a peer of @stoplight/ui-kit@^3 but none is installed. You must install peer dependencies yourself.
npm WARN @stoplight/[email protected] requires a peer of mobx@^5 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of mobx@^4.0.0 || ^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of react@^16.8.0 but none is installed. You must install peer dependencies yourself.
npm WARN @stoplight/[email protected] requires a peer of @stoplight/ui-kit@>=2 but none is installed. You must install peer dependencies yourself.
npm WARN @stoplight/[email protected] requires a peer of mobx@^5 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/[email protected] requires a peer of @babel/core@^7.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must install peer dependencies yourself.

Not sure which of the other peer dependencies may be required but if there is a flag that needs to be passed on install to pull in these required packages can you please let me know? And your install docs may need to be updated to reflect that.

[mpodlasin]

Hmm I see. I'll take a look then. Hang in there, I'll come back to you.

Sorry this took so much time BTW.

@Drethic, currently we are working on [email protected], which is in beta, but fairly stable at this point (we use it in our projects) and will be tagged to 4.0.0 very soon. It's leaner and has more up-to-date dependencies, so should work better for you. Perhaps you want to give it a try?

[mpodlasin]

I installed CRA, then @stoplightio/json-schema-viewer and then peer dependencies from the package.json: mobx, @stoplightio/markdown-viewer and @stoplight/ui-kit and it works.

I had a fresh install, so 1.0.1 vs 1.0.2 of ordered-object-literal didn't affect me, because I instantly got the newer version.

So please try to replicate that setup.

If it still fails, please make a repo of your failing project and share it with me here.

If you can't share that project, please try to create a fresh one and replicate the same problem. Otherwise it will be tricky for me to help. 🙏