strangerstudios / pmpro-cpt Goto Github PK

The code to redirect always redirects away even when you should have access.

Create 2 levels. Give yourself both levels. Mark one CPT post to require one level. Mark another CPT post to require the other level. Navigate to either CPT page.

The the_content filter still works well on archive views (probably because it's just core PMPro and MMPU).

Site get error 500 when upgrading frpm PmPro 2.02 -> 2.03 with this add-on activated

The current version of pmpro-cpt is not detecting sensei plugin custom posts (recipes).

Hi there,

Is it possible to adapt pmprocpt_getCPTs to search for custom taxonomy as well as CPTs?

Cheers

Rob

Describe the bug
A customer ran into an error on PHP 8.0+.

To Reproduce
Steps to reproduce the behavior:

1. Set PHP version to PHP 8.0+
2. Activate Paid Memberships Pro, and Custom Post Type Add On. See this error:

Error Details
=============
An error of type E_ERROR was caused in line 194 of the file /nas/content/live/wp-content/plugins/pmpro-cpt/pmpro-cpt.php. Error message: Uncaught TypeError: trim(): Argument #1 ($string) must be of type string, array given in /nas/content/live/wp-content/plugins/pmpro-cpt/pmpro-cpt.php:194
Stack trace:
#0 /nas/content/live/wp-content/plugins/pmpro-cpt/pmpro-cpt.php(194): trim(Array)
#1 /nas/content/live/wp-includes/class-wp-hook.php(310): pmprocpt_options_validate(Array)
#2 /nas/content/live/wp-includes/plugin.php(205): WP_Hook->apply_filters(Array, Array)
#3 /nas/content/live/wp-includes/formatting.php(5000): apply_filters(‘sanitize_option…’, Array, ‘pmprocpt_option…’, Array)
#4 /nas/content/live/wp-includes/option.php(638): sanitize_option(‘pmprocpt_option…’, Array)
#5 /nas/content/live/wp-includes/option.php(496): add_option(‘pmprocpt_option…’, Array, ”, ‘yes’)
#6 /nas/content/live/wp-admin/options.php(322): update_option(‘pmprocpt_option…’, Array)
#7 {main}
thrown

Expected behavior
There should not be an error.

Isolating the problem:

• Deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro 2.9.12, and Custom Post Type Add On 1.0 is active.
• This bug happens with a default WordPress theme active, or Memberlite.

This came up in ticket 465372 on PHP 8.0.26, and this error happened in my test with PHP 8.0.22.

WordPress Environment

This Add On needs to be localized.

Howdy,

If you don't have a redirect enabled for your CPT, yet wish to use the metabox, you get a php undefined index for line 24. Doesn't hurt much, but I try to remove them for cleaner troubleshooting. Here's the fix if you want it!

$redirect_to = isset($options['redirect_to'][0]) ? intval($options['redirect_to'][0]) : '';

Best,
Sarah

Just spotted that if I select a CPT to restrict access to, then save settings, then deselect all CPTs and save settings again, when I hit the front end, I get:

Fatal error: Cannot use string offset as an array in [...]/wp-content/plugins/pmpro-cpt/pmpro-cpt.php on line 24

Easy enough to work around, by selecting any CPT in the backend again, but could be a bit worrying for people.
(Unless my theme has somehow caused this - I haven't got any others installed atm so haven't checked.)

The PMPro CPT add on redirects non-members away from member content because we can't be sure how a CPT is displayed and if our basic the_content filter will properly protect the member content.

However, sometimes you know the content will be protected enough and would rather have the content filter and links to checkout/etc like we do for posts and pages by default.

This code disables the redirect entirely: https://gist.github.com/ideadude/76872d4ee982f7add05dafb69cf00d13

We could perhaps add a filter to the redirect code to disable it for specific CPTs.

We could then also consider adding UI to the settings to select some CPTs to redirect away from entirely and some to just filter. That probably needs a lot of thought because the concept is pretty hard to get I think. I'd like a solution that is not too complicated for users to manage and understand what is happening.

When a CPT post is created using Elementor Page Builder and the post is assigned a fee with Addon Packages plugin the post redirects to the member levels page instead of the checkout page for the addon package.

Our rule of thumb is that if an Add-On only works with PMPro active, then the settings page should be under Memberships.

Memberships -> Restrict CPTs