streamlink / streamlink-appimage Goto Github PK

The upgrade is currently blocked by missing wheels for Streamlink's dependencies, namely lxml:

# cp312 - lxml 4.9.3 (latest)
$ curl -sSL https://pypi.org/pypi/lxml/4.9.3/json | jq -r '.urls[] | select(.python_version == "cp312") | .filename'
lxml-4.9.3-cp312-cp312-macosx_11_0_universal2.whl
lxml-4.9.3-cp312-cp312-manylinux_2_28_aarch64.whl
lxml-4.9.3-cp312-cp312-manylinux_2_28_x86_64.whl
lxml-4.9.3-cp312-cp312-musllinux_1_1_aarch64.whl
lxml-4.9.3-cp312-cp312-musllinux_1_1_x86_64.whl
lxml-4.9.3-cp312-cp312-win_amd64.whl

# cp311 - lxml 4.9.3 (latest)
$ curl -sSL https://pypi.org/pypi/lxml/4.9.3/json | jq -r '.urls[] | select(.python_version == "cp311") | .filename'
lxml-4.9.3-cp311-cp311-macosx_11_0_universal2.whl
lxml-4.9.3-cp311-cp311-manylinux_2_12_i686.manylinux2010_i686.manylinux_2_24_i686.whl
lxml-4.9.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl
lxml-4.9.3-cp311-cp311-manylinux_2_28_aarch64.whl
lxml-4.9.3-cp311-cp311-manylinux_2_28_x86_64.whl
lxml-4.9.3-cp311-cp311-musllinux_1_1_aarch64.whl
lxml-4.9.3-cp311-cp311-musllinux_1_1_x86_64.whl
lxml-4.9.3-cp311-cp311-win32.whl
lxml-4.9.3-cp311-cp311-win_amd64.whl

# cp311 - lxml 4.9.2 (previous release)
$ curl -sSL https://pypi.org/pypi/lxml/4.9.2/json | jq -r '.urls[] | select(.python_version == "cp311") | .filename'
lxml-4.9.2-cp311-cp311-manylinux_2_12_i686.manylinux2010_i686.manylinux_2_24_i686.whl
lxml-4.9.2-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.manylinux_2_24_aarch64.whl
lxml-4.9.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl
lxml-4.9.2-cp311-cp311-musllinux_1_1_aarch64.whl
lxml-4.9.2-cp311-cp311-musllinux_1_1_x86_64.whl
lxml-4.9.2-cp311-cp311-win32.whl
lxml-4.9.2-cp311-cp311-win_amd64.whl

The cp312 i686 wheel is missing, and both the x86_64 and aarch64 wheels have been bumped from manylinux_2_17 (manylinux2014 is the old alias for that) to manylinux_2_28. The manylinux bump of aarch64 on 4.9.3 has already been a problem, hence the downgrade to 4.9.2 in recent AppImage releases.

This means that either the AppImages need to be bumped to manylinux_2_28, or the lxml wheels need to be built ourselves, by building libxml2 and libxslt (and their deps), and then lxml. However, there's probably a reason why wheels for older glibc versions were not built (no idea yet, haven't checked). On top of that, support for manylinux2014 aka. manylinux_2_17 will run out soon next year, it doesn't make sense adding workarounds and delaying the upgrade further.

The upgrade towards manylinux_2_28 is therefore inevitable. glibc 2.28 was released in August 2018 and most LTS distros from that era without that glibc version or newer should have already ended support by now, so upgrading shouldn't cause any issues in terms of user compatibility.

I will have a look at upgrading some time soon.

The AppImage build config and build scripts should be rewritten so that they match the ones of Streamlink's Windows builds (installers and portable archives). Streamlink's code should be retrieved from git instead of stable sdist releases from PyPI, and nightly builds should be published as build artifacts. Building dependencies from source instead of downloading pre-built wheels should also be explored, so we're not limited by any build- or infrastructure issues of the devs of Streamlink's dependencies (like lxml for example). Optionally, a changelog should be added and the GitHub release should have a message attached (release body).

• Update build config and scripts
  • Use the same script arguments as Streamlink's Windows build scripts
  • Retrieve Streamlink from git
  • Allow building from different git refs
  • Build dependencies from source
  • Ensure that everything stays reproducible
• Build and publish nightly builds
• GH releases body
• Add changelog

The same problem as niess/python-appimage#24 ?