Suggestion: consider removal of `includes` and `excludes` options about react-docgen-typescript-loader

[strothj]

@amacleay

Hello,

I've released a release candidate with this change.

You can review the change log here:
https://github.com/strothj/react-docgen-typescript-loader/blob/v3/README.md

The package is available as react-docgen-typescript-loader@next.

I'd like to release v3 this coming Wednesday. If you have any problems or feedback, it would be helpful.

[nickmccurdy]

This should be closed by 3.0.0, right?

[strothj]

You're using a monorepo setup correct? I think I ended up with a similar situation when doing something similar. I'll think this over in more detail on Sunday and see what direction I'd like to take here.

[strothj]

I'm looking into this.

The original concern for me was that I was using the babel-typescript-preset. The same loader is used for both Javascript and TypeScript compilation. I was also hoping to make the startup process of Storybook less CPU intensive on large projects by limiting the docgen to only Storybook stories.

I don't think this choice has made a measurable difference, the performance is still awful.

[amacleay]

Yes, I'm essentially using a monorepo setup.

(In fact, it's not actually currently set up as a monorepo, but it is an obvious candidate: more than one repo of component libraries, but one storybook repo to showcase together)

Thanks for taking a look!

[amacleay]

I tested with your new code and it does seem to do what's on the tin. Thanks!

While testing, though, I ran into another issue which requires a bit of work. I'll add that as another issue shortly. Thanks for all your work.

[strothj]

This should be closed by 3.0.0, right?

Yes, this was taken care of as v3. Thanks.