studiowaaz / waazaxeptaplugin Goto Github PK

View Code? Open in Web Editor NEW

0.0 4.0 1.0 83 KB

Gherkin 6.45% PHP 93.55%

waazaxeptaplugin's Issues

StatusAction should handle Failed payment

All in the title:

WaazAxeptaPlugin/src/Action/StatusAction.php

Line 62 in 47605bb

if ($status === PaymentInterface::STATE_CANCELLED) {

The StatusAction should also handle failed payments:

        if ($status === PaymentInterface::STATE_FAILED) {

            $request->markFailed();

            return;
        }

Sylius 1.11

Hello,

Do you plan any Sylius 1.11 update ?

If it's still compatible off course.

\Waaz\AxeptaPlugin\Action\NotifyAction::execute should check if state machine CAN before apply

In some rare case I got an exception returned to the PSP through the notification because the payment is unable to migrate to completed as it is already completed.:

This code:

$this->stateMachineFactory->get($payment, PaymentTransitions::GRAPH)->apply(PaymentTransitions::TRANSITION_COMPLETE);

Should migrate to:

$sm = $this->stateMachineFactory->get($payment, PaymentTransitions::GRAPH);
if ($sm->(PaymentTransitions::TRANSITION_COMPLETE)) {
    $sm->apply(PaymentTransitions::TRANSITION_COMPLETE);
}