Locks up atom when attempting to type closing </p> about language-javascript-jsx

[subtleGradient]

Thanks for the bug report!
I'll look into this when I can

[subtleGradient]

Confirmed. This happens for me too

[subtleGradient]

Oh crap! This may be my fault in a MUCH deeper way than I could have guessed!

Looks like this may be a problem in atom/slick, which is a fork of kamicane/slick, which is a project created by @kamicane, @subtleGradient (that's me), and @fabiomcosta!

Awesome!

[fabiomcosta]

Wait, Atom uses Slick? That's new to me, cool!

[subtleGradient]

@kevinsawicki, do you think this could be a Slick issue?
I haven't touched that code in a LONG time. I'll need to set aside some time to look into it properly.

One thing I know is that the Slick parser was never built to handle TextMate 2 selectors. In this language grammar, I'm using a bunch of replacement strings. e.g. foo.bar.baz.${2/something/}. Slick certainly can't handle that stuff, but I wouldn't have thought it would ∞ loop because of it. Clearly I didn't do enough testing :P

[subtleGradient]

Cf. https://github.com/subtleGradient/language-javascript-jsx/blob/master/grammars/JavaScript%20with%20JSX.cson#L121

[subtleGradient]

Actually, it looks like Slick is properly parsing meta.block.inner.${2/[:.]/-/g}.jsx as a meta element with the classList ['meta', 'block', 'inner', '${2/[:', ']/-/g}', 'jsx'].
Lulz

[subtleGradient]

@Inviz, do you have an improved version of the Slick parser hanging out anywhere?

[kevinsawicki]

Yeah, I've seen slick lock up in the past which is why Atom ships with fork of it, may need some tweaking to prevent other lockup scenarios

[apostoiis]

Yeap, this happens to me too. I'm writing the closing tag element first, and then I add the / so Atom doesn't crash. )

[subtleGradient]

Just published v0.3.3 with a fix for this.
Slick may have been a red herring.

Pro Tip™ TextMate handles way more edge cases than Atom. Scopes that select zero characters seem to be a problem.

[apostoiis]

Just tested it, works fine. thanks :)

[subtleGradient]

My fix in v0.3.3 broke JSX close tags without newlines before them. I just released v0.3.4 that fixes that new bug without unfixing this issue also. But I also added some extra scope to hi light improper close tags as invalid. Everything should be working great, but if not, as always, please do let me know.

Thanks much!