sugarlabs / convert Goto Github PK

Reproducer: enter a value for conversion, press convert, enter a different value.

Problem: result displayed is inconsistent with entered value.

Proposed solution: remove the convert button and do the conversion on each change to the value.

Reproducer: start, change dimension and units, stop, restart from journal entry.

Expected: dimension and units preserved.

Observed: dimension and units are reset to Length - Cables.

At the same time, add a reset button to restore dimension and units to defaults.

A child cannot easily learn the unit conversion ratios, because they are not shown.

With SUGAR_SCALING of 100, and org.sugarlabs.font default-size set to 7.0, on 1200x900 resolution, several problems appear.

• the dimensions radio buttons do not fit on the toolbar, forcing the stop button to a submenu.
• two of the new icons do not render properly,
• entering a conversion causes the main window to grow.

Tested with 5ad6553.

As of 7bb29e4 the result can be copied by selecting it and using a mouse drag or ctrl+c shortcut. A text clipping can be dragged from the frame into the input field. But there's no toolbar buttons.

Add an edit toolbar and buttons. See toolkit and other activities for an example edit toolbar and icons.

Reproducer: start, click on toolbar Volume button, observe unit text.

Expected: Centimeter³

Observed: HTML Centimeter<sup><b>3</b></sup>

Also occurs in similar fashion with squared units in Area mode.

Regression since 66531be.

To the left of the Convert button is a value entry widget.

On the GTK+ 2 version, this was rendered with spin buttons; up and down arrows vertically aligned.

On the GTK+ 3 version, this is rendered with spin buttons; - and + horizontally aligned.

However, spin buttons are not needed, are a distraction, and so a plain unadorned text entry can be used instead.

• starting the activity shows no units selected,
• switching between unit ranges using the toolbar doesn't select any default units,
• entering 9 shows 9.0 ~ -9.00000000001, it should be 9 ~ 9,
• there's no tooltip for the swap units button,
• swap of units changes to a different value with too many significant digits (e.g. select inches to millimetres, enter 1.0, click on swap, the entry box now contains 0.0393700787402 and the conversion 0.00155000310001)

On start units default to Length - Cables.

This is not a useful unit, and distracts by introducing a unit that learners are unlikely to encounter.

The units should either;

• not default, i.e. to an empty ComboBox item,
• default to an appropriate localised value taken from the po/ files, or;
• default to metric system.

Clicking in the result field shows a vertical bar cursor, also known as a text caret. Arrow keys can be used to move the cursor. The cursor may be mistaken for a digit.

Unit spinners on top far left and far right can be selected, but they don't show the current unit name.

At the moment the activity has;

• source unit (a menu),
• destination unit (a menu),
• source value (centered entry),
• source value and destination value (centered label),

An alternate design could be;

• source value (an entry on the left of display),
• source unit (a menu to the right or below the source value),
• destination value (an entry on the right of display).
• destination unit,

This would;

• make it clear what the unit is for each value,
• allow changes to the destination value,
• remove the need for a swap button.

Discuss?

🎯