sulu / suluredirectbundle Goto Github PK

Actual Behavior

The deserialization does skip and setter/getter and can overwrite changer, creator, ids which is a security issue how it is currently implemented.

Expected Behavior

Use the serializer just to serialize object to json but not json to object use normal setters instead.

Actual Behavior

If I work import the sourceHost field is empty

Expected Behavior

my value

Steps to Reproduce

in Converter.php add field "sourceHost"

Possible Solutions

add const SOURCE_HOST = 'sourceHost' and add this variable in foreach on line 54. (https://github.com/sulu/SuluRedirectBundle/blob/2.x/Import/Converter/Converter.php)

Actual Behavior

Currently the enabled/disabled is implemented as checkbox in the form.

Expected Behavior

As noted by @chirimoya things like enabled/disabled or published/unpublish should be a toolbar action and should call an own api endpoint which does just enable and disable this redirect.

Actual Behavior

In 1.x version of the redirect bundle there did exist a import overlay.

Expected Behavior

This should be reimplemented in for 2.0 when sulu provides a ImportToolbarAction:

sulu/sulu#4621

On this moment there is no information how the import is working. You can upload a csv file but you dont know what is needed for this import.

Is it possible to give feedback/information to the user how this redirect functionality is working?

Update:
Removed permissions info.

Actual Behavior

It throws an error on the filter-type attribute. See: https://github.com/danrot/sulu/blob/89512c37e28213b4a386cfef8e1eba4838e7220f/UPGRADE.md

Expected Behavior

Sulu redirect bundle should work with Sulu 2.1.*@dev

Steps to Reproduce

Use the sulu redirect bundle in a project with Sulu 2.1.*@dev

Possible Solutions

Remove the filter-type attribute for now. In the UPDATE.md it states that this attribute is not yet in use at all. I will make a PR for this.

Actual Behavior

Only tried in Google Chrome Browser

Import a CSV file with the two columns "source" and "target" result an error of:
The intl string context variable "fileName" was not provided to the string "Unexpected error while uploading {fileName, select, undefined{a file} other{the file {fileName}}} to the server."

Expected Behavior

Importing a CSV file with those two columns should be possible according to the docs.

Steps to Reproduce

Create a CSV file with the required columns "target" and "source" and try to import it.

Screenshots

Actual Behavior

Currently you can create a redirect rule e.g. source test.html which is invalid as it can never map as the slash is required /test.html.

Expected Behavior

Automatically add the / when saving or writing the url or validate it in the frontend.

Steps to Reproduce

Create rule with source test.html.

Possible Solutions

See expected behavior.

Mostly when you create a new website you can not create for all old urls redirects.
It would be good to have a 404 url list in the backend foreach webspace with a counter (which urls was called most) and the content manager create a redirect to a specific page / url.

Actual Behavior

So that it's translatable

Actual Behavior

When importing a file without header line (source,target) the import fails foreach line without message.

Expected Behavior

The import should work or fail with an accurate error message.

Steps to Reproduce

Upload csv file without header line.

Possible Solutions

There are two possible solutions:

1. use source,target as default header and try to import
2. detect this issue and return an accurate error message

Actual Behavior

Now it's not possible to install this bundle without change stability of composer to dev.

Expected Behavior

Install via composer with a stable version

Steps to Reproduce

composer require sulu/redirect-bundle ( with a clean install of sulu skeleton )

Possible Solutions

Tag a 2.0 version for Sulu. I don't know if something is missing or it's planned a release date ( if so, close this issue ) . If i can help, please tell me

Actual Behavior

If gone on remove is enabled and you try to remove a page in admin it fails.

GoneDocumentSubscriber try to save the page https://github.com/sulu/SuluRedirectBundle/blob/2.x/GoneSubscriber/GoneDocumentSubscriber.php#L100

but saveBydata method fails due to missing 'sourceHost' key

https://github.com/sulu/SuluRedirectBundle/blob/2.x/Manager/RedirectRouteManager.php#L41

Expected Behavior

The page is removed and redirect is created .

Possible Solutions

• Add coalescence operator in 'sourceHost'
• Refactor method to set all arguments with typehints (BC break)

Actual Behavior

Since #63 the redirect bundle lowercases all target URLs, which can make the whole redirect useless depending on whether the target application's URLs are case sensitive or not.

Expected Behavior

The target URL is adopted as it is entered.

Steps to Reproduce

Add a redirect to e.g. a Spotify playlist URL (which is case sensitive). When opening the source URL, the Spotify page you get redirected to will load forever or show an error page.

Possible Solutions

Remove the mb_strtolower call for the target URL.

Would you accept this change or would this be considered a BC break?

Actual Behavior

Gone subscriber can't be disabled.

Expected Behavior

Gone should be able to be disabled currently the service is always loaded.

Steps to Reproduce

Try to disable the gone subscriber over the configuraiton

Possible Solutions

Load gone_subscriber.xml only when enabled.

Actual Behavior

Currently there is no multi webspace / domain support. You can redirect to a specific domain but the source can not have a domain.

Expected Behavior

There should be an additional sourceHost property which should be set by the GoneSubscriber ({host} host will be replaced with null which is the same as matching for all domains). SourceHost can be empty so it will match all domains. If a source exist in both with and without a sourceHost it should use the redirect with the host.

Actual Behavior

The security-context currently only implement the VIEW permission.

Expected Behavior

This should be extended to ADD, EDIT, DELETE, UPDATE.

Actual Behavior

When I make a redirection from a source with .html extension, the redirect is available only if I don't specify sourceHost.

Expected Behavior

Redirect properly when defining a sourceHost.

Steps to Reproduce

source : test.html
sourceHost: your host or 127.0.0.1:8000
target : /

=> 404

source : test.html
sourceHost: empty host
target : /

=> It's 👍

Actual Behavior

Does not have Dutch language

Actual Behavior

Currently the unique key for source is case insensitive (by mysql default). This leads into that the redirect for /test will also work for /Test and the import will only allow one of them (but redirect both).

This has impact on the following code snippets:

• https://github.com/sulu/SuluRedirectBundle/pull/15/files#diff-02219834ba5c105e9f7790a812da31d0R60
• https://github.com/sulu/SuluRedirectBundle/pull/15/files#diff-02219834ba5c105e9f7790a812da31d0R119
• https://github.com/sulu/SuluRedirectBundle/blob/master/Resources/config/doctrine/RedirectRoute.orm.xml#L8

Expected Behavior

That should be discussed.

Possible Solutions

Do Nothing to keep case-insensitive unique-key or mark key as BINARY to make it case-sensitive.

Actual Behavior

Currently the redirect target is just a absolute url or absolute path.

Expected Behavior

It would be nice to redirect always to a specific page also when the page url changes. This could be done by using the link field type instead a text input.

Actual Behavior

Currently its not possible to delete redirects as the remove button is never activated.

Expected Behavior

The remove button should be enabled when a checkbox is marked in the list to remove a specific item.

Actual Behavior

Currently there is no export toolbar action and that is probably a bit confusing for users who want to import redirects, because they have no template at all about how the import csv file should look like.

Expected Behavior

There should be a export toolbar action